Sign upLogin

polyfony-inc/polyfony

View on GitHub
Star
Private/Polyfony/Route.php

Summary

Maintainability
D
2 days
Test Coverage

File Route.php has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
 
namespace Polyfony;

class Route {
Severity: Minor
Found in Private/Polyfony/Route.php - About 4 hrs to fix

Function validateThisParameter has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public function validateThisParameter(
        $parameter_index, 
        $parameter_value
    ) :bool {
        // if a constraint exists for a parameter in that position
Severity: Minor
Found in Private/Polyfony/Route.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Route has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Route {

    // url to match
    public ?string $url                        = null;
    // name of that route
Severity: Minor
Found in Private/Polyfony/Route.php - About 2 hrs to fix

Function hasValidSignature has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function hasValidSignature(
        array $request_parameters_indexed_by_position
    ) :bool {
        
        // if the route needs a signature to be a match
Severity: Minor
Found in Private/Polyfony/Route.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validateThisParameter has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validateThisParameter(
        $parameter_index, 
        $parameter_value
    ) :bool {
        // if a constraint exists for a parameter in that position
Severity: Major
Found in Private/Polyfony/Route.php - About 2 hrs to fix

Method hasValidSignature has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function hasValidSignature(
        array $request_parameters_indexed_by_position
    ) :bool {
        
        // if the route needs a signature to be a match
Severity: Minor
Found in Private/Polyfony/Route.php - About 1 hr to fix

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in Private/Polyfony/Route.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in Private/Polyfony/Route.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in Private/Polyfony/Route.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return true;
Severity: Major
Found in Private/Polyfony/Route.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in Private/Polyfony/Route.php - About 30 mins to fix

There are no issues that match your filters.

Category
Status