Sign upLogin

polyfox/moon-packages

View on GitHub
Star
lib/moon/packages/physics/sat.rb

Summary

Maintainability
D
3 days
Test Coverage

Method test_polygon_circle has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

      def test_polygon_circle(polygon, circle, response)
        # Get the position of the circle relative to the polygon.
        circle_pos = T_VECTORS.pop.set(circle.position - polygon.position)
        radius = circle.r
        radius2 = radius * radius
Severity: Minor
Found in lib/moon/packages/physics/sat.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File sat.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Moon
  # https://github.com/jriecken/sat-js
  module SAT
    class Polygon
      # @return [Moon::Vector2]
Severity: Minor
Found in lib/moon/packages/physics/sat.rb - About 5 hrs to fix

    Method is_separating_axis? has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

          def is_separating_axis?(a_pos, b_pos, a_points, b_points, axis, response)
        range_a = T_ARRAYS.pop
        range_b = T_ARRAYS.pop
        # The magnitude of the offset between the two polygons
        #offset_v = T_VECTORS.pop.set(b_pos).sub(a_pos)
    Severity: Minor
    Found in lib/moon/packages/physics/sat.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method test_polygon_circle has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def test_polygon_circle(polygon, circle, response)
        # Get the position of the circle relative to the polygon.
        circle_pos = T_VECTORS.pop.set(circle.position - polygon.position)
        radius = circle.r
        radius2 = radius * radius
    Severity: Major
    Found in lib/moon/packages/physics/sat.rb - About 3 hrs to fix

      Method is_separating_axis? has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def is_separating_axis?(a_pos, b_pos, a_points, b_points, axis, response)
        range_a = T_ARRAYS.pop
        range_b = T_ARRAYS.pop
        # The magnitude of the offset between the two polygons
        #offset_v = T_VECTORS.pop.set(b_pos).sub(a_pos)
      Severity: Minor
      Found in lib/moon/packages/physics/sat.rb - About 2 hrs to fix

        Method is_separating_axis? has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def is_separating_axis?(a_pos, b_pos, a_points, b_points, axis, response)
        Severity: Minor
        Found in lib/moon/packages/physics/sat.rb - About 45 mins to fix

          Method aabb has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def aabb
        xmn = @calc_points[0].x
        ymn = @calc_points[0].y
        xmx = @calc_points[0].x
        ymx = @calc_points[0].y
          Severity: Minor
          Found in lib/moon/packages/physics/sat.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      response.b_in_a = false
            # B ends before A ends. We have to push A out of B
            if range_a[1] > range_b[1]
              overlap = range_a[0] - range_b[1]
              response.a_in_b = false
          Severity: Major
          Found in lib/moon/packages/physics/sat.rb and 1 other location - About 1 hr to fix
          lib/moon/packages/physics/sat.rb on lines 243..253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      response.a_in_b = false
            # A ends before B does. We have to pull A out of B
            if range_a[1] < range_b[1]
              overlap = range_a[1] - range_b[0]
              response.b_in_a = false
          Severity: Major
          Found in lib/moon/packages/physics/sat.rb and 1 other location - About 1 hr to fix
          lib/moon/packages/physics/sat.rb on lines 256..266

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status