Sign upLogin

portainer/portainer

View on GitHub
Star
api/datastore/migrator/migrate_ce.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Migrator.Migrate has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func (m *Migrator) Migrate() error {
    version, err := m.versionService.Version()
    if err != nil {
        return migrationError(err, "get version service")
    }
Severity: Minor
Found in api/datastore/migrator/migrate_ce.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Migrator.Migrate has 7 return statements (exceeds 4 allowed).
Open

func (m *Migrator) Migrate() error {
    version, err := m.versionService.Version()
    if err != nil {
        return migrationError(err, "get version service")
    }
Severity: Major
Found in api/datastore/migrator/migrate_ce.go - About 45 mins to fix

    Method Migrator.NeedsMigration has 5 return statements (exceeds 4 allowed).
    Open

    func (m *Migrator) NeedsMigration() bool {
    // we need to migrate if anything changes with the version in the DB vs what our software version is.
    // If the version matches, then it's all down to the number of migration funcs we have for the current version
    // i.e. the MigratorCount
    Severity: Major
    Found in api/datastore/migrator/migrate_ce.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status