Sign upLogin

portainer/portainer

View on GitHub
Star
api/datastore/migrator/migrate_dbversion31.go

Summary

Maintainability
C
1 day
Test Coverage

Method Migrator.updateDockerhubToDB32 has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (m *Migrator) updateDockerhubToDB32() error {
    log.Info().Msg("updating dockerhub")

    dockerhub, err := m.dockerhubService.DockerHub()
    if dataservices.IsErrObjectNotFound(err) {
Severity: Minor
Found in api/datastore/migrator/migrate_dbversion31.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Migrator.updateDockerhubToDB32 has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *Migrator) updateDockerhubToDB32() error {
    log.Info().Msg("updating dockerhub")

    dockerhub, err := m.dockerhubService.DockerHub()
    if dataservices.IsErrObjectNotFound(err) {
Severity: Minor
Found in api/datastore/migrator/migrate_dbversion31.go - About 1 hr to fix

    Method Migrator.updateVolumeResourceControlToDB32 has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (m *Migrator) updateVolumeResourceControlToDB32() error {
    log.Info().Msg("updating resource controls")

    endpoints, err := m.endpointService.Endpoints()
    if err != nil {
    Severity: Minor
    Found in api/datastore/migrator/migrate_dbversion31.go - About 1 hr to fix

      Method Migrator.updateVolumeResourceControlToDB32 has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (m *Migrator) updateVolumeResourceControlToDB32() error {
    log.Info().Msg("updating resource controls")

    endpoints, err := m.endpointService.Endpoints()
    if err != nil {
      Severity: Minor
      Found in api/datastore/migrator/migrate_dbversion31.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Migrator.migrateDBVersionToDB32 has 6 return statements (exceeds 4 allowed).
      Open

      func (m *Migrator) migrateDBVersionToDB32() error {
    err := m.updateRegistriesToDB32()
    if err != nil {
        return err
    }
      Severity: Major
      Found in api/datastore/migrator/migrate_dbversion31.go - About 40 mins to fix

        Method Migrator.updateDockerhubToDB32 has 6 return statements (exceeds 4 allowed).
        Open

        func (m *Migrator) updateDockerhubToDB32() error {
    log.Info().Msg("updating dockerhub")

    dockerhub, err := m.dockerhubService.DockerHub()
    if dataservices.IsErrObjectNotFound(err) {
        Severity: Major
        Found in api/datastore/migrator/migrate_dbversion31.go - About 40 mins to fix

          Method Migrator.updateVolumeResourceControlToDB32 has 5 return statements (exceeds 4 allowed).
          Open

          func (m *Migrator) updateVolumeResourceControlToDB32() error {
    log.Info().Msg("updating resource controls")

    endpoints, err := m.endpointService.Endpoints()
    if err != nil {
          Severity: Major
          Found in api/datastore/migrator/migrate_dbversion31.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (m *Migrator) helmRepositoryURLToDB32() error {
    log.Info().Msg("setting default helm repository URL")

    settings, err := m.settingsService.Settings()
    if err != nil {
            Severity: Minor
            Found in api/datastore/migrator/migrate_dbversion31.go and 1 other location - About 30 mins to fix
            api/datastore/migrator/migrate_dbversion31.go on lines 263..273

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (m *Migrator) kubeconfigExpiryToDB32() error {
    log.Info().Msg("updating kubeconfig expiry")

    settings, err := m.settingsService.Settings()
    if err != nil {
            Severity: Minor
            Found in api/datastore/migrator/migrate_dbversion31.go and 1 other location - About 30 mins to fix
            api/datastore/migrator/migrate_dbversion31.go on lines 275..285

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status