Sign upLogin

portainer/portainer

View on GitHub
Star
api/docker/container.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method ContainerService.Recreate has 103 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *ContainerService) Recreate(ctx context.Context, endpoint *portainer.Endpoint, containerId string, forcePullImage bool, imageTag, nodeName string) (*types.ContainerJSON, error) {
    cli, err := c.factory.CreateClient(endpoint, nodeName, nil)
    if err != nil {
        return nil, errors.Wrap(err, "create client error")
    }
Severity: Major
Found in api/docker/container.go - About 3 hrs to fix

    Method ContainerService.Recreate has 13 return statements (exceeds 4 allowed).
    Open

    func (c *ContainerService) Recreate(ctx context.Context, endpoint *portainer.Endpoint, containerId string, forcePullImage bool, imageTag, nodeName string) (*types.ContainerJSON, error) {
    cli, err := c.factory.CreateClient(endpoint, nodeName, nil)
    if err != nil {
        return nil, errors.Wrap(err, "create client error")
    }
    Severity: Major
    Found in api/docker/container.go - About 1 hr to fix

      Method ContainerService.Recreate has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
      Open

      func (c *ContainerService) Recreate(ctx context.Context, endpoint *portainer.Endpoint, containerId string, forcePullImage bool, imageTag, nodeName string) (*types.ContainerJSON, error) {
    cli, err := c.factory.CreateClient(endpoint, nodeName, nil)
    if err != nil {
        return nil, errors.Wrap(err, "create client error")
    }
      Severity: Minor
      Found in api/docker/container.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ContainerService.Recreate has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (c *ContainerService) Recreate(ctx context.Context, endpoint *portainer.Endpoint, containerId string, forcePullImage bool, imageTag, nodeName string) (*types.ContainerJSON, error) {
      Severity: Minor
      Found in api/docker/container.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status