Sign upLogin

portainer/portainer

View on GitHub
Star
api/docker/snapshot.go

Summary

Maintainability
C
1 day
Test Coverage

Function snapshotContainers has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
Open

func snapshotContainers(snapshot *portainer.DockerSnapshot, cli *client.Client) error {
    containers, err := cli.ContainerList(context.Background(), container.ListOptions{All: true})
    if err != nil {
        return err
    }
Severity: Minor
Found in api/docker/snapshot.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function snapshotContainers has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func snapshotContainers(snapshot *portainer.DockerSnapshot, cli *client.Client) error {
    containers, err := cli.ContainerList(context.Background(), container.ListOptions{All: true})
    if err != nil {
        return err
    }
Severity: Minor
Found in api/docker/snapshot.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if gpuOptions.Count == -1 {
                        gpuUseAll = true
                    }
    Severity: Major
    Found in api/docker/snapshot.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if !strings.Contains(err.Error(), "No such container") {
                        return err
                    }
      Severity: Major
      Found in api/docker/snapshot.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status