portainer/portainer

View on GitHub
api/http/handler/customtemplates/customtemplate_create.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Handler.createCustomTemplateFromGitRepository has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) createCustomTemplateFromGitRepository(r *http.Request) (*portainer.CustomTemplate, error) {
    var payload customTemplateFromGitRepositoryPayload
    err := request.DecodeAndValidateJSONPayload(r, &payload)
    if err != nil {
        return nil, err
Severity: Minor
Found in api/http/handler/customtemplates/customtemplate_create.go - About 1 hr to fix

    Method customTemplateFromFileUploadPayload.Validate has 9 return statements (exceeds 4 allowed).
    Open

    func (payload *customTemplateFromFileUploadPayload) Validate(r *http.Request) error {
        title, err := request.RetrieveMultiPartFormValue(r, "Title", false)
        if err != nil {
            return errors.New("Invalid custom template title")
        }
    Severity: Major
    Found in api/http/handler/customtemplates/customtemplate_create.go - About 55 mins to fix

      Method Handler.createCustomTemplateFromGitRepository has 9 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) createCustomTemplateFromGitRepository(r *http.Request) (*portainer.CustomTemplate, error) {
          var payload customTemplateFromGitRepositoryPayload
          err := request.DecodeAndValidateJSONPayload(r, &payload)
          if err != nil {
              return nil, err
      Severity: Major
      Found in api/http/handler/customtemplates/customtemplate_create.go - About 55 mins to fix

        Method customTemplateFromGitRepositoryPayload.Validate has 8 return statements (exceeds 4 allowed).
        Open

        func (payload *customTemplateFromGitRepositoryPayload) Validate(r *http.Request) error {
            if govalidator.IsNull(payload.Title) {
                return errors.New("Invalid custom template title")
            }
            if govalidator.IsNull(payload.Description) {
        Severity: Major
        Found in api/http/handler/customtemplates/customtemplate_create.go - About 50 mins to fix

          Method Handler.customTemplateCreate has 8 return statements (exceeds 4 allowed).
          Open

          func (handler *Handler) customTemplateCreate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
              method, err := request.RetrieveRouteVariableValue(r, "method")
              if err != nil {
                  return httperror.BadRequest("Invalid query parameter: method", err)
              }
          Severity: Major
          Found in api/http/handler/customtemplates/customtemplate_create.go - About 50 mins to fix

            Method customTemplateFromFileContentPayload.Validate has 7 return statements (exceeds 4 allowed).
            Open

            func (payload *customTemplateFromFileContentPayload) Validate(r *http.Request) error {
                if govalidator.IsNull(payload.Title) {
                    return errors.New("Invalid custom template title")
                }
                if govalidator.IsNull(payload.Description) {
            Severity: Major
            Found in api/http/handler/customtemplates/customtemplate_create.go - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  customTemplate := &portainer.CustomTemplate{
                      ID:              portainer.CustomTemplateID(customTemplateID),
                      Title:           payload.Title,
                      Description:     payload.Description,
                      Note:            payload.Note,
              Severity: Minor
              Found in api/http/handler/customtemplates/customtemplate_create.go and 1 other location - About 40 mins to fix
              api/http/handler/customtemplates/customtemplate_create.go on lines 471..482

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  customTemplate := &portainer.CustomTemplate{
                      ID:           portainer.CustomTemplateID(customTemplateID),
                      Title:        payload.Title,
                      Description:  payload.Description,
                      Note:         payload.Note,
              Severity: Minor
              Found in api/http/handler/customtemplates/customtemplate_create.go and 1 other location - About 40 mins to fix
              api/http/handler/customtemplates/customtemplate_create.go on lines 281..292

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status