Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/customtemplates/customtemplate_update.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Handler.customTemplateUpdate has 92 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) customTemplateUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    customTemplateID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Custom template identifier route variable", err)
    }
Severity: Major
Found in api/http/handler/customtemplates/customtemplate_update.go - About 2 hrs to fix

    Method Handler.customTemplateUpdate has 14 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) customTemplateUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    customTemplateID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Custom template identifier route variable", err)
    }
    Severity: Major
    Found in api/http/handler/customtemplates/customtemplate_update.go - About 1 hr to fix

      Method Handler.customTemplateUpdate has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (handler *Handler) customTemplateUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    customTemplateID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Custom template identifier route variable", err)
    }
      Severity: Minor
      Found in api/http/handler/customtemplates/customtemplate_update.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method customTemplateUpdatePayload.Validate has 9 return statements (exceeds 4 allowed).
      Open

      func (payload *customTemplateUpdatePayload) Validate(r *http.Request) error {
    if govalidator.IsNull(payload.Title) {
        return errors.New("Invalid custom template title")
    }
    if govalidator.IsNull(payload.FileContent) && govalidator.IsNull(payload.RepositoryURL) {
      Severity: Major
      Found in api/http/handler/customtemplates/customtemplate_update.go - About 55 mins to fix

        There are no issues that match your filters.

        Category
        Status