Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/edgegroups/edgegroup_update.go

Summary

Maintainability
C
1 day
Test Coverage

Method Handler.edgeGroupUpdate has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
Open

func (handler *Handler) edgeGroupUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    edgeGroupID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Edge group identifier route variable", err)
    }
Severity: Minor
Found in api/http/handler/edgegroups/edgegroup_update.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Handler.edgeGroupUpdate has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) edgeGroupUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    edgeGroupID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Edge group identifier route variable", err)
    }
Severity: Major
Found in api/http/handler/edgegroups/edgegroup_update.go - About 2 hrs to fix

    Method Handler.edgeGroupUpdate has 17 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) edgeGroupUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    edgeGroupID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid Edge group identifier route variable", err)
    }
    Severity: Major
    Found in api/http/handler/edgegroups/edgegroup_update.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (payload *edgeGroupUpdatePayload) Validate(r *http.Request) error {
    if govalidator.IsNull(payload.Name) {
        return errors.New("invalid Edge group name")
    }
      Severity: Minor
      Found in api/http/handler/edgegroups/edgegroup_update.go and 1 other location - About 35 mins to fix
      api/http/handler/edgegroups/edgegroup_create.go on lines 24..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status