Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/edgejobs/edgejob_update.go

Summary

Maintainability
C
1 day
Test Coverage

Method Handler.updateEdgeSchedule has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
Open

func (handler *Handler) updateEdgeSchedule(tx dataservices.DataStoreTx, edgeJob *portainer.EdgeJob, payload *edgeJobUpdatePayload) error {
    if payload.Name != nil {
        edgeJob.Name = *payload.Name
    }
Severity: Minor
Found in api/http/handler/edgejobs/edgejob_update.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Handler.updateEdgeSchedule has 113 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) updateEdgeSchedule(tx dataservices.DataStoreTx, edgeJob *portainer.EdgeJob, payload *edgeJobUpdatePayload) error {
    if payload.Name != nil {
        edgeJob.Name = *payload.Name
    }
Severity: Major
Found in api/http/handler/edgejobs/edgejob_update.go - About 3 hrs to fix

    Method Handler.updateEdgeSchedule has 9 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) updateEdgeSchedule(tx dataservices.DataStoreTx, edgeJob *portainer.EdgeJob, payload *edgeJobUpdatePayload) error {
    if payload.Name != nil {
        edgeJob.Name = *payload.Name
    }
    Severity: Major
    Found in api/http/handler/edgejobs/edgejob_update.go - About 55 mins to fix

      Method Handler.updateEdgeJob has 5 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) updateEdgeJob(tx dataservices.DataStoreTx, edgeJobID portainer.EdgeJobID, payload edgeJobUpdatePayload) (*portainer.EdgeJob, error) {
    edgeJob, err := tx.EdgeJob().Read(portainer.EdgeJobID(edgeJobID))
    if tx.IsErrObjectNotFound(err) {
        return nil, httperror.NotFound("Unable to find an Edge job with the specified identifier inside the database", err)
    } else if err != nil {
      Severity: Major
      Found in api/http/handler/edgejobs/edgejob_update.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status