Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/endpoints/endpoint_create.go

Summary

Maintainability
C
1 day
Test Coverage

Method endpointCreatePayload.Validate has 97 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (payload *endpointCreatePayload) Validate(r *http.Request) error {
    name, err := request.RetrieveMultiPartFormValue(r, "Name", false)
    if err != nil {
        return errors.New("invalid environment name")
    }
Severity: Major
Found in api/http/handler/endpoints/endpoint_create.go - About 2 hrs to fix

    Method endpointCreatePayload.Validate has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
    Open

    func (payload *endpointCreatePayload) Validate(r *http.Request) error {
    name, err := request.RetrieveMultiPartFormValue(r, "Name", false)
    if err != nil {
        return errors.New("invalid environment name")
    }
    Severity: Minor
    Found in api/http/handler/endpoints/endpoint_create.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Handler.endpointCreate has 59 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (handler *Handler) endpointCreate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    payload := &endpointCreatePayload{}
    err := payload.Validate(r)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)
    Severity: Minor
    Found in api/http/handler/endpoints/endpoint_create.go - About 1 hr to fix

      Method endpointCreatePayload.Validate has 13 return statements (exceeds 4 allowed).
      Open

      func (payload *endpointCreatePayload) Validate(r *http.Request) error {
    name, err := request.RetrieveMultiPartFormValue(r, "Name", false)
    if err != nil {
        return errors.New("invalid environment name")
    }
      Severity: Major
      Found in api/http/handler/endpoints/endpoint_create.go - About 1 hr to fix

        Method Handler.endpointCreate has 9 return statements (exceeds 4 allowed).
        Open

        func (handler *Handler) endpointCreate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    payload := &endpointCreatePayload{}
    err := payload.Validate(r)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)
        Severity: Major
        Found in api/http/handler/endpoints/endpoint_create.go - About 55 mins to fix

          Method Handler.createEdgeAgentEndpoint has 5 return statements (exceeds 4 allowed).
          Open

          func (handler *Handler) createEdgeAgentEndpoint(tx dataservices.DataStoreTx, payload *endpointCreatePayload) (*portainer.Endpoint, *httperror.HandlerError) {
    endpointID := handler.DataStore.Endpoint().GetNextIdentifier()

    portainerHost, err := edge.ParseHostForEdge(payload.URL)
    if err != nil {
          Severity: Major
          Found in api/http/handler/endpoints/endpoint_create.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status