Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/endpoints/endpoint_delete.go

Summary

Maintainability
C
1 day
Test Coverage

Method Handler.deleteEndpoint has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func (handler *Handler) deleteEndpoint(tx dataservices.DataStoreTx, endpointID portainer.EndpointID, deleteCluster bool) error {
    endpoint, err := tx.Endpoint().Endpoint(portainer.EndpointID(endpointID))
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find an environment with the specified identifier inside the database", err)
    } else if err != nil {
Severity: Minor
Found in api/http/handler/endpoints/endpoint_delete.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Handler.deleteEndpoint has 107 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) deleteEndpoint(tx dataservices.DataStoreTx, endpointID portainer.EndpointID, deleteCluster bool) error {
    endpoint, err := tx.Endpoint().Endpoint(portainer.EndpointID(endpointID))
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find an environment with the specified identifier inside the database", err)
    } else if err != nil {
Severity: Major
Found in api/http/handler/endpoints/endpoint_delete.go - About 3 hrs to fix

    Method Handler.endpointDelete has 7 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) endpointDelete(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid environment identifier route variable", err)
    }
    Severity: Major
    Found in api/http/handler/endpoints/endpoint_delete.go - About 45 mins to fix

      Method Handler.deleteEndpoint has 5 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) deleteEndpoint(tx dataservices.DataStoreTx, endpointID portainer.EndpointID, deleteCluster bool) error {
    endpoint, err := tx.Endpoint().Endpoint(portainer.EndpointID(endpointID))
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find an environment with the specified identifier inside the database", err)
    } else if err != nil {
      Severity: Major
      Found in api/http/handler/endpoints/endpoint_delete.go - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            for idx := range registries {
        registry := &registries[idx]
        if _, ok := registry.RegistryAccesses[endpoint.ID]; ok {
            delete(registry.RegistryAccesses, endpoint.ID)
            err = tx.Registry().Update(registry.ID, registry)
        Severity: Major
        Found in api/http/handler/endpoints/endpoint_delete.go and 2 other locations - About 50 mins to fix
        api/http/handler/endpoints/endpoint_delete.go on lines 136..145
        api/http/handler/endpoints/endpoint_delete.go on lines 169..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                for idx := range edgeJobs {
            edgeJob := &edgeJobs[idx]
            if _, ok := edgeJob.Endpoints[endpoint.ID]; ok {
                delete(edgeJob.Endpoints, endpoint.ID)
        Severity: Major
        Found in api/http/handler/endpoints/endpoint_delete.go and 2 other locations - About 50 mins to fix
        api/http/handler/endpoints/endpoint_delete.go on lines 136..145
        api/http/handler/endpoints/endpoint_delete.go on lines 152..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            for idx := range edgeStacks {
        edgeStack := &edgeStacks[idx]
        if _, ok := edgeStack.Status[endpoint.ID]; ok {
            delete(edgeStack.Status, endpoint.ID)
            err = tx.EdgeStack().UpdateEdgeStack(edgeStack.ID, edgeStack)
        Severity: Major
        Found in api/http/handler/endpoints/endpoint_delete.go and 2 other locations - About 50 mins to fix
        api/http/handler/endpoints/endpoint_delete.go on lines 152..161
        api/http/handler/endpoints/endpoint_delete.go on lines 169..179

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status