Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/endpoints/endpoint_registries_list.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Handler.listRegistries has 7 return statements (exceeds 4 allowed).
Open

func (handler *Handler) listRegistries(tx dataservices.DataStoreTx, r *http.Request, endpointID portainer.EndpointID) ([]portainer.Registry, error) {
    securityContext, err := security.RetrieveRestrictedRequestContext(r)
    if err != nil {
        return nil, httperror.InternalServerError("Unable to retrieve info from request context", err)
    }
Severity: Major
Found in api/http/handler/endpoints/endpoint_registries_list.go - About 45 mins to fix

    Method Handler.filterKubernetesEndpointRegistries has 6 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) filterKubernetesEndpointRegistries(r *http.Request, registries []portainer.Registry, endpoint *portainer.Endpoint, user *portainer.User, memberships []portainer.TeamMembership) ([]portainer.Registry, *httperror.HandlerError) {
    namespaceParam, _ := request.RetrieveQueryParameter(r, "namespace", true)
    isAdmin, err := security.IsAdmin(r)
    if err != nil {
        return nil, httperror.InternalServerError("Unable to check user role", err)
    Severity: Major
    Found in api/http/handler/endpoints/endpoint_registries_list.go - About 40 mins to fix

      Method Handler.isNamespaceAuthorized has 6 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) isNamespaceAuthorized(endpoint *portainer.Endpoint, namespace string, userId portainer.UserID, memberships []portainer.TeamMembership, isAdmin bool) (bool, error) {
    if isAdmin || namespace == "" {
        return true, nil
    }
      Severity: Major
      Found in api/http/handler/endpoints/endpoint_registries_list.go - About 40 mins to fix

        Method Handler.isNamespaceAuthorized has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (handler *Handler) isNamespaceAuthorized(endpoint *portainer.Endpoint, namespace string, userId portainer.UserID, memberships []portainer.TeamMembership, isAdmin bool) (bool, error) {
        Severity: Minor
        Found in api/http/handler/endpoints/endpoint_registries_list.go - About 35 mins to fix

          Method Handler.filterKubernetesEndpointRegistries has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (handler *Handler) filterKubernetesEndpointRegistries(r *http.Request, registries []portainer.Registry, endpoint *portainer.Endpoint, user *portainer.User, memberships []portainer.TeamMembership) ([]portainer.Registry, *httperror.HandlerError) {
          Severity: Minor
          Found in api/http/handler/endpoints/endpoint_registries_list.go - About 35 mins to fix

            Method Handler.filterRegistriesByAccess has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (handler *Handler) filterRegistriesByAccess(r *http.Request, registries []portainer.Registry, endpoint *portainer.Endpoint, user *portainer.User, memberships []portainer.TeamMembership) ([]portainer.Registry, *httperror.HandlerError) {
            Severity: Minor
            Found in api/http/handler/endpoints/endpoint_registries_list.go - About 35 mins to fix

              Method Handler.endpointRegistriesList has 5 return statements (exceeds 4 allowed).
              Open

              func (handler *Handler) endpointRegistriesList(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid environment identifier route variable", err)
    }
              Severity: Major
              Found in api/http/handler/endpoints/endpoint_registries_list.go - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status