Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/endpoints/endpoint_update.go

Summary

Maintainability
D
2 days
Test Coverage

Method Handler.endpointUpdate has a Cognitive Complexity of 83 (exceeds 20 allowed). Consider refactoring.
Open

func (handler *Handler) endpointUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid environment identifier route variable", err)
    }
Severity: Minor
Found in api/http/handler/endpoints/endpoint_update.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Handler.endpointUpdate has 183 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) endpointUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid environment identifier route variable", err)
    }
Severity: Major
Found in api/http/handler/endpoints/endpoint_update.go - About 6 hrs to fix

    Method Handler.endpointUpdate has 16 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) endpointUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid environment identifier route variable", err)
    }
    Severity: Major
    Found in api/http/handler/endpoints/endpoint_update.go - About 1 hr to fix

      Function shouldReloadTLSConfiguration has 5 return statements (exceeds 4 allowed).
      Open

      func shouldReloadTLSConfiguration(endpoint *portainer.Endpoint, payload *endpointUpdatePayload) bool {

    // If we change anything in the tls config then we need to reload the proxy
    if payload.TLS != nil && endpoint.TLSConfig.TLS != *payload.TLS {
        return true
      Severity: Major
      Found in api/http/handler/endpoints/endpoint_update.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status