portainer/portainer

View on GitHub
api/http/handler/endpoints/endpoint_update_relations.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Handler.updateRelations has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (handler *Handler) updateRelations(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {

    payload, err := request.GetPayload[endpointUpdateRelationsPayload](r)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)
Severity: Minor
Found in api/http/handler/endpoints/endpoint_update_relations.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Handler.updateRelations has 9 return statements (exceeds 4 allowed).
Open

func (handler *Handler) updateRelations(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {

    payload, err := request.GetPayload[endpointUpdateRelationsPayload](r)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)
Severity: Major
Found in api/http/handler/endpoints/endpoint_update_relations.go - About 55 mins to fix

    There are no issues that match your filters.

    Category
    Status