Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/kubernetes/handler.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Handler.kubeClientMiddleware has 69 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) kubeClientMiddleware(next http.Handler) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        if handler.KubernetesClientFactory == nil {
            next.ServeHTTP(w, r)
            return
Severity: Minor
Found in api/http/handler/kubernetes/handler.go - About 1 hr to fix

    Function NewHandler has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewHandler(bouncer security.BouncerService, authorizationService *authorization.Service, dataStore dataservices.DataStore, jwtService portainer.JWTService, kubeClusterAccessService kubernetes.KubeClusterAccessService, kubernetesClientFactory *cli.ClientFactory, kubernetesClient portainer.KubeClient) *Handler {
    Severity: Major
    Found in api/http/handler/kubernetes/handler.go - About 50 mins to fix

      Method Handler.kubeClientMiddleware has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func (handler *Handler) kubeClientMiddleware(next http.Handler) http.Handler {
    return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        if handler.KubernetesClientFactory == nil {
            next.ServeHTTP(w, r)
            return
      Severity: Minor
      Found in api/http/handler/kubernetes/handler.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status