portainer/portainer

Function createStackPayloadFromK8sGitPayload has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

func createStackPayloadFromK8sGitPayload(name, repoUrl, repoReference, repoUsername, repoPassword string, repoAuthentication, composeFormat bool, namespace, manifest string, additionalFiles []string, autoUpdate *portainer.AutoUpdateSettings, repoSkipSSLVerify bool) stackbuilders.StackPayload {

Method Handler.createKubernetesStackFromGitRepository has 7 return statements (exceeds 4 allowed).

Open

func (handler *Handler) createKubernetesStackFromGitRepository(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    if !endpointutils.IsKubernetesEndpoint(endpoint) {
        return httperror.BadRequest("Environment type does not match", errors.New("Environment type does not match"))
    }

Method kubernetesGitDeploymentPayload.Validate has 5 return statements (exceeds 4 allowed).

Open

func (payload *kubernetesGitDeploymentPayload) Validate(r *http.Request) error {
    if govalidator.IsNull(payload.RepositoryURL) || !govalidator.IsURL(payload.RepositoryURL) {
        return errors.New("Invalid repository URL. Must correspond to a valid URL format")
    }
    if payload.RepositoryAuthentication && govalidator.IsNull(payload.RepositoryPassword) {

Method Handler.createKubernetesStackFromFileContent has 5 return statements (exceeds 4 allowed).

Open

func (handler *Handler) createKubernetesStackFromFileContent(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    if !endpointutils.IsKubernetesEndpoint(endpoint) {
        return httperror.BadRequest("Environment type does not match", errors.New("Environment type does not match"))
    }

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if payload.AutoUpdate != nil && payload.AutoUpdate.Webhook != "" {
        isUnique, err := handler.checkUniqueWebhookID(payload.AutoUpdate.Webhook)
        if err != nil {
            return httperror.InternalServerError("Unable to check for webhook ID collision", err)
        }

• Read up
  Read up