portainer/portainer

Method Handler.createSwarmStackFromGitRepository has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (handler *Handler) createSwarmStackFromGitRepository(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    var payload swarmStackFromGitRepositoryPayload
    err := request.DecodeAndValidateJSONPayload(r, &payload)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)

Function createStackPayloadFromSwarmGitPayload has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

func createStackPayloadFromSwarmGitPayload(name, swarmID, repoUrl, repoReference, repoUsername, repoPassword string, repoAuthentication bool, composeFile string, additionalFiles []string, autoUpdate *portainer.AutoUpdateSettings, env []portainer.Pair, fromAppTemplate bool, repoSkipSSLVerify bool) stackbuilders.StackPayload {

Method Handler.createSwarmStackFromGitRepository has 8 return statements (exceeds 4 allowed).

Open

func (handler *Handler) createSwarmStackFromGitRepository(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    var payload swarmStackFromGitRepositoryPayload
    err := request.DecodeAndValidateJSONPayload(r, &payload)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)

Method Handler.createSwarmStackFromFileContent has 6 return statements (exceeds 4 allowed).

Open

func (handler *Handler) createSwarmStackFromFileContent(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    var payload swarmStackFromFileContentPayload
    err := request.DecodeAndValidateJSONPayload(r, &payload)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)

Method Handler.createSwarmStackFromFileUpload has 6 return statements (exceeds 4 allowed).

Open

func (handler *Handler) createSwarmStackFromFileUpload(w http.ResponseWriter, r *http.Request, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
    var payload swarmStackFromFileUploadPayload
    err := payload.Validate(r)
    if err != nil {
        return httperror.BadRequest("Invalid request payload", err)

Method swarmStackFromGitRepositoryPayload.Validate has 6 return statements (exceeds 4 allowed).

Open

func (payload *swarmStackFromGitRepositoryPayload) Validate(r *http.Request) error {
    if govalidator.IsNull(payload.Name) {
        return errors.New("Invalid stack name")
    }
    if govalidator.IsNull(payload.SwarmID) {

Function createStackPayloadFromSwarmFileContentPayload has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

func createStackPayloadFromSwarmFileContentPayload(name string, swarmID string, fileContent string, env []portainer.Pair, fromAppTemplate bool) stackbuilders.StackPayload {

Method swarmStackFromFileUploadPayload.Validate has 5 return statements (exceeds 4 allowed).

Open

func (payload *swarmStackFromFileUploadPayload) Validate(r *http.Request) error {
    name, err := request.RetrieveMultiPartFormValue(r, "Name", false)
    if err != nil {
        return errors.New("Invalid stack name")
    }

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if payload.AutoUpdate != nil && payload.AutoUpdate.Webhook != "" {
        isUnique, err := handler.checkUniqueWebhookID(payload.AutoUpdate.Webhook)
        if err != nil {
            return httperror.InternalServerError("Unable to check for webhook ID collision", err)
        }

• Read up
  Read up