Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/stacks/stack_start.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method Handler.stackStart has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *Handler) stackStart(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    stackID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid stack identifier route variable", err)
    }
Severity: Major
Found in api/http/handler/stacks/stack_start.go - About 2 hrs to fix

    Method Handler.stackStart has 21 return statements (exceeds 4 allowed).
    Open

    func (handler *Handler) stackStart(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    stackID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid stack identifier route variable", err)
    }
    Severity: Major
    Found in api/http/handler/stacks/stack_start.go - About 1 hr to fix

      Method Handler.stackStart has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

      func (handler *Handler) stackStart(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    stackID, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid stack identifier route variable", err)
    }
      Severity: Minor
      Found in api/http/handler/stacks/stack_start.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Handler.startStack has 7 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) startStack(
    stack *portainer.Stack,
    endpoint *portainer.Endpoint,
    securityContext *security.RestrictedRequestContext,
) error {
      Severity: Major
      Found in api/http/handler/stacks/stack_start.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status