Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/tags/tag_delete.go

Summary

Maintainability
C
1 day
Test Coverage

Function deleteTag has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func deleteTag(tx dataservices.DataStoreTx, tagID portainer.TagID) error {
    tag, err := tx.Tag().Read(tagID)
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find a tag with the specified identifier inside the database", err)
    } else if err != nil {
Severity: Minor
Found in api/http/handler/tags/tag_delete.go - About 1 hr to fix

    Function deleteTag has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func deleteTag(tx dataservices.DataStoreTx, tagID portainer.TagID) error {
    tag, err := tx.Tag().Read(tagID)
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find a tag with the specified identifier inside the database", err)
    } else if err != nil {
    Severity: Minor
    Found in api/http/handler/tags/tag_delete.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deleteTag has 16 return statements (exceeds 4 allowed).
    Open

    func deleteTag(tx dataservices.DataStoreTx, tagID portainer.TagID) error {
    tag, err := tx.Tag().Read(tagID)
    if tx.IsErrObjectNotFound(err) {
        return httperror.NotFound("Unable to find a tag with the specified identifier inside the database", err)
    } else if err != nil {
    Severity: Major
    Found in api/http/handler/tags/tag_delete.go - About 1 hr to fix

      Method Handler.tagDelete has 5 return statements (exceeds 4 allowed).
      Open

      func (handler *Handler) tagDelete(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    id, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid tag identifier route variable", err)
    }
      Severity: Major
      Found in api/http/handler/tags/tag_delete.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (handler *Handler) tagDelete(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    id, err := request.RetrieveNumericRouteVariableValue(r, "id")
    if err != nil {
        return httperror.BadRequest("Invalid tag identifier route variable", err)
    }
        Severity: Major
        Found in api/http/handler/tags/tag_delete.go and 1 other location - About 1 hr to fix
        api/http/handler/edgegroups/edgegroup_delete.go on lines 26..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 164.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for endpointGroupID := range tag.EndpointGroups {
        endpointGroup, err := tx.EndpointGroup().Read(endpointGroupID)
        if err != nil {
            return httperror.InternalServerError("Unable to retrieve environment group from the database", err)
        }
        Severity: Major
        Found in api/http/handler/tags/tag_delete.go and 1 other location - About 1 hr to fix
        api/http/handler/tags/tag_delete.go on lines 59..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for endpointID := range tag.Endpoints {
        endpoint, err := tx.Endpoint().Endpoint(endpointID)
        if err != nil {
            return httperror.InternalServerError("Unable to retrieve environment from the database", err)
        }
        Severity: Major
        Found in api/http/handler/tags/tag_delete.go and 1 other location - About 1 hr to fix
        api/http/handler/tags/tag_delete.go on lines 75..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status