Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/handler/websocket/pod.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Handler.websocketPodExec has 16 return statements (exceeds 4 allowed).
Open

func (handler *Handler) websocketPodExec(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericQueryParameter(r, "endpointId", false)
    if err != nil {
        return httperror.BadRequest("Invalid query parameter: endpointId", err)
    }
Severity: Major
Found in api/http/handler/websocket/pod.go - About 1 hr to fix

    Method Handler.websocketPodExec has 61 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (handler *Handler) websocketPodExec(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
    endpointID, err := request.RetrieveNumericQueryParameter(r, "endpointId", false)
    if err != nil {
        return httperror.BadRequest("Invalid query parameter: endpointId", err)
    }
    Severity: Minor
    Found in api/http/handler/websocket/pod.go - About 1 hr to fix

      Method Handler.hijackPodExecStartOperation has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          w http.ResponseWriter,
    r *http.Request,
    cli portainer.KubeClient,
    serviceAccountToken string,
    isAdminToken bool,
      Severity: Major
      Found in api/http/handler/websocket/pod.go - About 50 mins to fix

        Method Handler.getToken has 7 return statements (exceeds 4 allowed).
        Open

        func (handler *Handler) getToken(request *http.Request, endpoint *portainer.Endpoint, setLocalAdminToken bool) (string, bool, error) {
    tokenData, err := security.RetrieveTokenData(request)
    if err != nil {
        return "", false, err
    }
        Severity: Major
        Found in api/http/handler/websocket/pod.go - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if endpoint.Type == portainer.AgentOnKubernetesEnvironment {
        err := handler.proxyAgentWebsocketRequest(w, r, params)
        if err != nil {
            return httperror.InternalServerError("Unable to proxy websocket request to agent", err)
        }
          Severity: Minor
          Found in api/http/handler/websocket/pod.go and 1 other location - About 45 mins to fix
          api/http/handler/websocket/shell_pod.go on lines 87..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status