Sign upLogin

portainer/portainer

View on GitHub
Star
api/http/proxy/factory/docker/access_control.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Transport.newResourceControlFromPortainerLabels has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (transport *Transport) newResourceControlFromPortainerLabels(labelsObject map[string]interface{}, resourceID string, resourceType portainer.ResourceControlType) (*portainer.ResourceControl, error) {
    if labelsObject[resourceLabelForPortainerPublicResourceControl] != nil {
        resourceControl := authorization.NewPublicResourceControl(resourceID, resourceType)

        err := transport.dataStore.ResourceControl().Create(resourceControl)
Severity: Minor
Found in api/http/proxy/factory/docker/access_control.go - About 1 hr to fix

    Method Transport.applyAccessControlOnResource has 6 return statements (exceeds 4 allowed).
    Open

    func (transport *Transport) applyAccessControlOnResource(parameters *resourceOperationParameters, responseObject map[string]interface{}, response *http.Response, executor *operationExecutor) error {
    if responseObject[parameters.resourceIdentifierAttribute] == nil {
        log.Warn().
            Str("identifier_attribute", parameters.resourceIdentifierAttribute).
            Msg("unable to find resource identifier property in resource object")
    Severity: Major
    Found in api/http/proxy/factory/docker/access_control.go - About 40 mins to fix

      Method Transport.findResourceControl has 6 return statements (exceeds 4 allowed).
      Open

      func (transport *Transport) findResourceControl(resourceIdentifier string, resourceType portainer.ResourceControlType, resourceLabelsObject map[string]interface{}, resourceControls []portainer.ResourceControl) (*portainer.ResourceControl, error) {
    resourceControl := authorization.GetResourceControlByResourceIDAndType(resourceIdentifier, resourceType, resourceControls)
    if resourceControl != nil {
        return resourceControl, nil
    }
      Severity: Major
      Found in api/http/proxy/factory/docker/access_control.go - About 40 mins to fix

        Method Transport.newResourceControlFromPortainerLabels has 5 return statements (exceeds 4 allowed).
        Open

        func (transport *Transport) newResourceControlFromPortainerLabels(labelsObject map[string]interface{}, resourceID string, resourceType portainer.ResourceControlType) (*portainer.ResourceControl, error) {
    if labelsObject[resourceLabelForPortainerPublicResourceControl] != nil {
        resourceControl := authorization.NewPublicResourceControl(resourceID, resourceType)

        err := transport.dataStore.ResourceControl().Create(resourceControl)
        Severity: Major
        Found in api/http/proxy/factory/docker/access_control.go - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func (transport *Transport) createPrivateResourceControl(resourceIdentifier string, resourceType portainer.ResourceControlType, userID portainer.UserID) (*portainer.ResourceControl, error) {
    resourceControl := authorization.NewPrivateResourceControl(resourceIdentifier, resourceType, userID)

    err := transport.dataStore.ResourceControl().Create(resourceControl)
    if err != nil {
          Severity: Major
          Found in api/http/proxy/factory/docker/access_control.go and 1 other location - About 1 hr to fix
          api/http/proxy/factory/azure/access_control.go on lines 60..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 149.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func decorateObject(object map[string]interface{}, resourceControl *portainer.ResourceControl) map[string]interface{} {
    if object["Portainer"] == nil {
        object["Portainer"] = make(map[string]interface{})
    }
          Severity: Minor
          Found in api/http/proxy/factory/docker/access_control.go and 1 other location - About 40 mins to fix
          api/http/proxy/factory/azure/access_control.go on lines 50..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status