Sign upLogin

portainer/portainer

View on GitHub
Star
app/portainer/authorization-guard.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function checkAuthorizations has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

export async function checkAuthorizations(transition: Transition) {
  const authService: IAuthenticationService = transition
    .injector()
    .get('Authentication');
  const stateTo = transition.to();
Severity: Minor
Found in app/portainer/authorization-guard.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkAuthorizations has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function checkAuthorizations(transition: Transition) {
  const authService: IAuthenticationService = transition
    .injector()
    .get('Authentication');
  const stateTo = transition.to();
Severity: Minor
Found in app/portainer/authorization-guard.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return $state.target('portainer.home');
    Severity: Major
    Found in app/portainer/authorization-guard.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return undefined;
      Severity: Major
      Found in app/portainer/authorization-guard.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return $state.target('portainer.home');
        Severity: Major
        Found in app/portainer/authorization-guard.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return undefined;
          Severity: Major
          Found in app/portainer/authorization-guard.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return $state.target('portainer.home');
            Severity: Major
            Found in app/portainer/authorization-guard.ts - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status