Sign upLogin

portainer/portainer

View on GitHub
Star
app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx

Summary

Maintainability
D
3 days
Test Coverage

Consider simplifying this complex logical expression.
Open

                if (
                  (matchExpression.operator === 'Exists' && exists) ||
                  (matchExpression.operator === 'DoesNotExist' && !exists) ||
                  (matchExpression.operator === 'In' && isIn) ||
                  (matchExpression.operator === 'NotIn' && !isIn) ||
Severity: Critical
Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 4 hrs to fix

    Function computeAffinities has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function computeAffinities(
  nodes: Node[],
  nodePlacements: NodePlacementRowData[],
  pod: Pod
): NodePlacementRowData[] {
    Severity: Minor
    Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function computeAffinities has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function computeAffinities(
  nodes: Node[],
  nodePlacements: NodePlacementRowData[],
  pod: Pod
): NodePlacementRowData[] {
    Severity: Major
    Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 2 hrs to fix

      Function nodePlacementsFromAffinities has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (node, nodeIndex) => {
      let { acceptsApplication } = nodePlacements[nodeIndex];

      if (pod.spec?.nodeSelector) {
        const patch = JsonPatch.compare(
      Severity: Major
      Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 2 hrs to fix

        Function computeTolerations has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function computeTolerations(nodes: Node[], pod: Pod): NodePlacementRowData[] {
  const tolerations = pod.spec?.tolerations || [];
  const nodePlacements: NodePlacementRowData[] = nodes.map((node) => {
    let acceptsApplication = true;
    const unmetTaints: Taint[] = [];
        Severity: Major
        Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 2 hrs to fix

          Function nodePlacements has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const nodePlacements: NodePlacementRowData[] = nodes.map((node) => {
    let acceptsApplication = true;
    const unmetTaints: Taint[] = [];
    const taints = node.spec?.taints || [];
    taints.forEach((taint) => {
          Severity: Minor
          Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 2 hrs to fix

            Function usePlacementTableData has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function usePlacementTableData() {
  const placementsTableState = usePlacementTableState();
  const autoRefreshRate = placementsTableState.autoRefreshRate * 1000; // ms to seconds

  const stateAndParams = useCurrentStateAndParams();
            Severity: Minor
            Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 1 hr to fix

              Function unmatchedTerms has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                        (selectorTerm) => {
            const unmatchedExpressions = selectorTerm.matchExpressions?.flatMap(
              (matchExpression) => {
                const exists = {}.hasOwnProperty.call(
                  node.metadata?.labels,
              Severity: Minor
              Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 1 hr to fix

                Function unmatchedExpressions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                              (matchExpression) => {
                const exists = {}.hasOwnProperty.call(
                  node.metadata?.labels,
                  matchExpression.key
                );
                Severity: Minor
                Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                    (matchExpression.operator === 'Exists' && exists) ||
                  (matchExpression.operator === 'DoesNotExist' && !exists) ||
                  (matchExpression.operator === 'In' && isIn) ||
                  (matchExpression.operator === 'NotIn' && !isIn) ||
                  (matchExpression.operator === 'Gt' &&
                  Severity: Major
                  Found in app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx and 1 other location - About 1 hr to fix
                  app/react/kubernetes/applications/DetailsView/PlacementsDatatable/usePlacementTableData.tsx on lines 210..225

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 64.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status