Sign upLogin

portainer/portainer

View on GitHub
Star
app/react/kubernetes/applications/application.queries.ts

Summary

Maintainability
C
1 day
Test Coverage

File application.queries.ts has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { UseQueryResult, useMutation, useQuery } from '@tanstack/react-query';
import { Pod } from 'kubernetes-types/core/v1';

import { queryClient, withError } from '@/react-tools/react-query';
import { EnvironmentId } from '@/react/portainer/environments/types';
Severity: Minor
Found in app/react/kubernetes/applications/application.queries.ts - About 4 hrs to fix

    Function useApplicationHorizontalPodAutoscaler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function useApplicationHorizontalPodAutoscaler(
  environmentId: EnvironmentId,
  namespace: string,
  appName: string,
  app?: Application
    Severity: Minor
    Found in app/react/kubernetes/applications/application.queries.ts - About 1 hr to fix

      Function useRedeployApplicationMutation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function useRedeployApplicationMutation(
  environmentId: number,
  namespace: string,
  name: string
) {
      Severity: Minor
      Found in app/react/kubernetes/applications/application.queries.ts - About 1 hr to fix

        Function usePatchApplicationMutation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function usePatchApplicationMutation(
  environmentId: EnvironmentId,
  namespace: string,
  name: string
) {
        Severity: Minor
        Found in app/react/kubernetes/applications/application.queries.ts - About 1 hr to fix

          Function useApplicationRevisionList has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            environmentId: EnvironmentId,
  namespace: string,
  name: string,
  deploymentUid?: string,
  labelSelector?: string,
          Severity: Minor
          Found in app/react/kubernetes/applications/application.queries.ts - About 45 mins to fix

            Function useApplication has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              environmentId: EnvironmentId,
  namespace: string,
  name: string,
  appKind?: AppKind,
  options?: { autoRefreshRate?: number; yaml?: boolean }
            Severity: Minor
            Found in app/react/kubernetes/applications/application.queries.ts - About 35 mins to fix

              Function useApplicationPods has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                environmentId: EnvironmentId,
  namespace: string,
  appName: string,
  app?: Application,
  options?: { autoRefreshRate?: number }
              Severity: Minor
              Found in app/react/kubernetes/applications/application.queries.ts - About 35 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                export function useApplication<T extends Application | string = Application>(
  environmentId: EnvironmentId,
  namespace: string,
  name: string,
  appKind?: AppKind,
                Severity: Minor
                Found in app/react/kubernetes/applications/application.queries.ts and 1 other location - About 30 mins to fix
                app/react/kubernetes/applications/DetailsView/ApplicationEventsDatatable.tsx on lines 53..111

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status