Sign upLogin

portainer/portainer

View on GitHub
Star
app/react/kubernetes/applications/application.service.ts

Summary

Maintainability
D
2 days
Test Coverage

File application.service.ts has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  DaemonSetList,
  StatefulSetList,
  DeploymentList,
  Deployment,
Severity: Minor
Found in app/react/kubernetes/applications/application.service.ts - About 4 hrs to fix

    Function getApplication has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function getApplication<
  T extends Application | string = Application,
>(
  environmentId: EnvironmentId,
  namespace: string,
    Severity: Major
    Found in app/react/kubernetes/applications/application.service.ts - About 2 hrs to fix

      Function getApplicationRevisionList has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function getApplicationRevisionList(
  environmentId: EnvironmentId,
  namespace: string,
  deploymentUid?: string,
  appKind?: AppKind,
      Severity: Major
      Found in app/react/kubernetes/applications/application.service.ts - About 2 hrs to fix

        Function patchApplication has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function patchApplication(
  environmentId: EnvironmentId,
  namespace: string,
  appKind: AppKind,
  name: string,
        Severity: Minor
        Found in app/react/kubernetes/applications/application.service.ts - About 1 hr to fix

          Function patchApplicationByKind has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            environmentId: EnvironmentId,
  namespace: string,
  appKind: 'Deployment' | 'DaemonSet' | 'StatefulSet',
  name: string,
  patch: ApplicationPatch,
          Severity: Minor
          Found in app/react/kubernetes/applications/application.service.ts - About 45 mins to fix

            Function patchApplication has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              environmentId: EnvironmentId,
  namespace: string,
  appKind: AppKind,
  name: string,
  patch: ApplicationPatch,
            Severity: Minor
            Found in app/react/kubernetes/applications/application.service.ts - About 45 mins to fix

              Function getApplicationRevisionList has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                environmentId: EnvironmentId,
  namespace: string,
  deploymentUid?: string,
  appKind?: AppKind,
  labelSelector?: string
              Severity: Minor
              Found in app/react/kubernetes/applications/application.service.ts - About 35 mins to fix

                Function getApplicationByKind has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  environmentId: EnvironmentId,
  namespace: string,
  appKind: 'Deployment' | 'DaemonSet' | 'StatefulSet',
  name: string,
  yaml?: boolean
                Severity: Minor
                Found in app/react/kubernetes/applications/application.service.ts - About 35 mins to fix

                  Function getApplication has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    environmentId: EnvironmentId,
  namespace: string,
  name: string,
  appKind?: AppKind,
  yaml?: boolean
                  Severity: Minor
                  Found in app/react/kubernetes/applications/application.service.ts - About 35 mins to fix

                    Function getApplication has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export async function getApplication<
  T extends Application | string = Application,
>(
  environmentId: EnvironmentId,
  namespace: string,
                    Severity: Minor
                    Found in app/react/kubernetes/applications/application.service.ts - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export async function getControllerRevisionList(
  environmentId: EnvironmentId,
  namespace: string,
  labelSelector?: string
) {
                    Severity: Major
                    Found in app/react/kubernetes/applications/application.service.ts and 1 other location - About 3 hrs to fix
                    app/react/kubernetes/applications/application.service.ts on lines 326..344

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 100.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export async function getReplicaSetList(
  environmentId: EnvironmentId,
  namespace: string,
  labelSelector?: string
) {
                    Severity: Major
                    Found in app/react/kubernetes/applications/application.service.ts and 1 other location - About 3 hrs to fix
                    app/react/kubernetes/applications/application.service.ts on lines 346..367

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 100.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status