portainer/portainer

View on GitHub
app/react/kubernetes/applications/components/ApplicationSummarySection/utils.ts

Summary

Maintainability
D
1 day
Test Coverage

File utils.ts has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Ingress } from '@/react/kubernetes/ingresses/types';

import { ServiceFormValues } from '../../CreateView/application-services/types';
import { ApplicationFormValues } from '../../types';
import {

    Function getUpdatedApplicationResources has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getUpdatedApplicationResources(
      newFormValues: ApplicationFormValues,
      oldFormValues: ApplicationFormValues
    ) {
      // app summaries

      Function getCreatedApplicationResourcesNew has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getCreatedApplicationResourcesNew(
        formValues: ApplicationFormValues
      ): Array<Summary> {
        // app summary
        const appSummary: Summary = {

        Function getPVCSummaries has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getPVCSummaries(
          newFormValues: ApplicationFormValues,
          oldFormValues?: ApplicationFormValues
        ): Array<Summary> {
          // only create pvc summaries for new pvcs

          Function getServiceUpdateResourceSummary has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getServiceUpdateResourceSummary(
            oldServices?: Array<ServiceFormValues>,
            newServices?: Array<ServiceFormValues>
          ): Array<Summary> {
            const updateAndCreateSummaries =

            Function getPVCSummaries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function getPVCSummaries(
              newFormValues: ApplicationFormValues,
              oldFormValues?: ApplicationFormValues
            ): Array<Summary> {
              // only create pvc summaries for new pvcs

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status