Sign upLogin

prantlf/nettime

View on GitHub
Star

Showing 10 of 11 total issues

Function makeSingleRequest has 249 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeSingleRequest (options) {
  return new Promise((resolve, reject) => {
    const timings = {}
    const { outputFile, returnResponse, includeHeaders } = options
    let data = (outputFile || returnResponse) && Buffer.from([])
Severity: Major
Found in lib/nettime.js - About 1 day to fix

    Function computeAverageDurations has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

    export function computeAverageDurations (timings) {
  const timingCount = timings.length
  const durations = createEventDurations()
  computeEventDurations()
  checkSkippedEvents()
    Severity: Minor
    Found in lib/timings.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File nettime.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { writeFile } from 'fs'
import http from 'http'
import https from 'https'
import http2 from 'http2'
import { EOL } from 'os'
    Severity: Minor
    Found in lib/nettime.js - About 3 hrs to fix

      Function computeAverageDurations has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function computeAverageDurations (timings) {
  const timingCount = timings.length
  const durations = createEventDurations()
  computeEventDurations()
  checkSkippedEvents()
      Severity: Major
      Found in lib/timings.js - About 2 hrs to fix

        Function nettime has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function nettime (options) {
  if (typeof options === 'string') {
    options = { url: options }
  }
  const { requestCount, requestDelay, followRedirects } = options
        Severity: Minor
        Found in lib/nettime.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getParameters has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function getParameters () {
      const { url, data, rejectUnauthorized, credentials } = options
      const headers = options.headers || {}
      const parameters = parseURL()
      setSecurity()
        Severity: Major
        Found in lib/nettime.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (durationValues[0] === undefined) {
        for (let i = 0; i < timingCount; ++i) {
          if (durationValues[i] !== undefined) {
            throw new Error(`Unexpected event ${event} timing of the request ${i}.`)
          }
          Severity: Major
          Found in lib/timings.js and 1 other location - About 1 hr to fix
          lib/timings.js on lines 66..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                } else {
        for (let i = 0; i < timingCount; ++i) {
          if (durationValues[i] === undefined) {
            throw new Error(`Expected event ${event} timing of the request ${i}.`)
          }
          Severity: Major
          Found in lib/timings.js and 1 other location - About 1 hr to fix
          lib/timings.js on lines 60..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function writeOutputFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function writeOutputFile () {
      if (includeHeaders && response) {
        prependOutputHeader()
      }
      const flag = options.appendToOutput ? 'a' : 'w'
          Severity: Minor
          Found in lib/nettime.js - About 1 hr to fix

            Function parseURL has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  function parseURL () {
        const {
          protocol, username, password, host, hostname, port, pathname, search
        } = new URL(url)
        const auth = username
            Severity: Minor
            Found in lib/nettime.js - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language