Sign upLogin

prasadtalasila/BITS-Darshini

View on GitHub
Star
src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java

Summary

Maintainability
A
0 mins
Test Coverage

Define a constant instead of duplicating this literal "Session " 3 times.
Open

        log.info("Session " + this.sessionName + "::Starting linkcell at: " + time);
Severity: Critical
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

This block of commented-out lines of code should be removed.
Open

        /* repository.terminate(); */
Severity: Major
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by sonar-java

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.transport.TransportAnalyzer' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.transport.TransportAnalyzer;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.network.NetworkAnalyzer' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.network.NetworkAnalyzer;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.persistence.repository.AnalysisRepository' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.persistence.repository.AnalysisRepository;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent'
Open

import in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Summary javadoc is missing.
Open

/**
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks thatJavadoc summary sentence does not contain phrases that are not recommended to use.Summaries that contain only the {@inheritDoc} tag are skipped. Check alsoviolate Javadoc that does not contain first sentence.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'lombok.extern.log4j.Log4j' import. Should be before 'org.springframework.stereotype.Component'.
Open

import lombok.extern.log4j.Log4j;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.springframework.beans.factory.annotation.Autowired'
Open

import org.springframework.beans.factory.annotation.Autowired;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.protocol.Protocol' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.protocol.Protocol;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'lombok.Getter' import. Should be before 'org.springframework.stereotype.Component'.
Open

import lombok.Getter;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.link.LinkAnalyzer' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.link.LinkAnalyzer;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/analyzer/Session.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status