Sign upLogin

prasadtalasila/BITS-Darshini

View on GitHub
Star
src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void run() {
        this.isRunning = true;
        while (!buckets.isEmpty()) {
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

This block of commented-out lines of code should be removed.
Open

            //runtime.gc();
Severity: Major
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by sonar-java

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

This block of commented-out lines of code should be removed.
Open

        //log.info("Publishing end of Save Repository");
Severity: Major
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by sonar-java

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

This block of commented-out lines of code should be removed.
Open

        //log.info("Save repo received signal that analysis has ended");
Severity: Major
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by sonar-java

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try {
            Context ctx = new InitialContext();
            Context env = (Context) ctx.lookup("java:comp/env");
            lowWaterMark = Integer.parseInt((String) env.lookup("lowWaterMark"));
            log.info("LOW WATER MARK READ FROM FILE IS: " + lowWaterMark);
Severity: Major
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java and 1 other location - About 1 hr to fix
src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/AnalysisRepository.java on lines 54..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Wrong lexicographical order for 'javax.naming.InitialContext' import. Should be before 'org.springframework.stereotype.Component'.
Open

import javax.naming.InitialContext;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.event.EndAnalysisEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'com.google.common.eventbus.EventBus' import. Should be before 'org.springframework.stereotype.Component'.
Open

import com.google.common.eventbus.EventBus;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 119).
Open

            log.info("EXCEPTION IN READING FROM CONFIG FILE FOR analysisOnly .. setting false by default");
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'javax.naming.NamingException' import. Should be before 'org.springframework.stereotype.Component'.
Open

import javax.naming.NamingException;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'javax.naming.Context' import. Should be before 'org.springframework.stereotype.Component'.
Open

import javax.naming.Context;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'com.google.common.eventbus.Subscribe' import. Should be before 'org.springframework.stereotype.Component'.
Open

import com.google.common.eventbus.Subscribe;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'com.google.common.eventbus.EventBus'
Open

import com.google.common.eventbus.EventBus;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.event.SaveRepoEndEvent' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.event.SaveRepoEndEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.springframework.beans.factory.annotation.Autowired'
Open

import org.springframework.beans.factory.annotation.Autowired;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'in.ac.bits.protocolanalyzer.analyzer.event.BucketLimitEvent'
Open

import in.ac.bits.protocolanalyzer.analyzer.event.BucketLimitEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 107).
Open

            log.info(System.currentTimeMillis() + " Used memory is megabytes: "+ bytesToMegabytes(memory));
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'javax.naming.Context'
Open

import javax.naming.Context;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'in.ac.bits.protocolanalyzer.analyzer.event.BucketLimitEvent' import. Should be before 'org.springframework.stereotype.Component'.
Open

import in.ac.bits.protocolanalyzer.analyzer.event.BucketLimitEvent;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 140).
Open

                    "SaveRepository started at " + System.currentTimeMillis() + " with bucket size: " + buckets.size());
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'lombok.extern.log4j.Log4j'
Open

import lombok.extern.log4j.Log4j;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 115).
Open

    *    Since AnalysisRepository is blocked when SaveRepository is running, this thread itself ensures that
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Open

    private static final long MEGABYTE = 1024L * 1024L;
Severity: Minor
Found in src/main/java/in/ac/bits/protocolanalyzer/persistence/repository/SaveRepository.java by pmd

FieldDeclarationsShouldBeAtStartOfClass

Since: PMD 5.0

Priority: Medium

Categories: Style

Remediation Points: 50000

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Example:

public class HelloWorldBean {

 // Field declared before methods / inner classes - OK
 private String _thing;

 public String getMessage() {
 return 'Hello World!';
 }

 // Field declared after methods / inner classes - avoid this
 private String _fieldInWrongLocation;
}

There are no issues that match your filters.

Category
Status