Sign upLogin

prasadtalasila/IRCLogParser

View on GitHub
Star
lib/analysis/channel.py

Summary

Maintainability
F
5 days
Test Coverage

Function response_time has a Cognitive Complexity of 133 (exceeds 5 allowed). Consider refactoring.
Open

def response_time(log_dict, nicks, nick_same_list, cutoff_percentile):

    """ finds the response time of a message
    i.e. the best guess for the time at which one can expect a reply for his/her message.
Severity: Minor
Found in lib/analysis/channel.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function conv_len_conv_refr_time has a Cognitive Complexity of 80 (exceeds 5 allowed). Consider refactoring.
Open

def conv_len_conv_refr_time(log_dict, nicks, nick_same_list, rt_cutoff_time, cutoff_percentile):

    """ Calculates the conversation length (CL) that is the length of time for which two users communicate
    i.e. if a message is not replied to within Response Time(RT),
    then it is considered as a part of another conversation.
Severity: Minor
Found in lib/analysis/channel.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function response_time. (33)
Open

def response_time(log_dict, nicks, nick_same_list, cutoff_percentile):

    """ finds the response time of a message
    i.e. the best guess for the time at which one can expect a reply for his/her message.
Severity: Minor
Found in lib/analysis/channel.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

File channel.py has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import re
import numpy
from networkx.algorithms.components.connected import connected_components
import lib.util as util
import lib.config as config
Severity: Minor
Found in lib/analysis/channel.py - About 3 hrs to fix

Cyclomatic complexity is too high in function conv_len_conv_refr_time. (9)
Open

def conv_len_conv_refr_time(log_dict, nicks, nick_same_list, rt_cutoff_time, cutoff_percentile):

    """ Calculates the conversation length (CL) that is the length of time for which two users communicate
    i.e. if a message is not replied to within Response Time(RT),
    then it is considered as a part of another conversation.
Severity: Minor
Found in lib/analysis/channel.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function truncate_table. (6)
Open

def truncate_table(table, cutoff_percentile):

    """
    The calculations of conversation characteristics, namely RT, CL and CRT, are
    based on the cutoff values estimated for RT and CL. This generic function takes
Severity: Minor
Found in lib/analysis/channel.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function truncate_table has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def truncate_table(table, cutoff_percentile):

    """
    The calculations of conversation characteristics, namely RT, CL and CRT, are
    based on the cutoff values estimated for RT and CL. This generic function takes
Severity: Minor
Found in lib/analysis/channel.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_conversation has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def build_conversation(rec_list, nick, send_time, nick_to_search,
Severity: Major
Found in lib/analysis/channel.py - About 1 hr to fix

Function conv_helper has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def conv_helper(rec, nick, send_time, nick_to_search, nick_receiver,
Severity: Major
Found in lib/analysis/channel.py - About 1 hr to fix

Function resp_helper has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def resp_helper(rec, nick, send_time, nick_to_search, nick_receiver, nick_sender, conversations, conn_comp_list):
Severity: Major
Found in lib/analysis/channel.py - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

                    if(len(conversations[i]) == 3):
                        conversations[i][2] = int(conversations[i][2][0:2])*config.MINS_PER_HOUR+int(conversations[i][2][3:5])
                    else:
                        del conversations[i][-1]
Severity: Major
Found in lib/analysis/channel.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        for nick in nicks:
                            rec_list = [e.strip() for e in line.split(':')]
                            util.rec_list_splice(rec_list)
                            if not rec_list[1]:
                                break
Severity: Major
Found in lib/analysis/channel.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    for nick in nicks:
                        rec_list = [e.strip() for e in line.split(':')]
                        util.rec_list_splice(rec_list)

                        if not rec_list[1]:
Severity: Major
Found in lib/analysis/channel.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    for j in range(2, len(conversations[i]) - 1):
                        conversations[i][j]=(int(conversations[i][j+1][0:2])*config.MINS_PER_HOUR+int(conversations[i][j+1][3:5])) - (int(conversations[i][j][0:2])*config.MINS_PER_HOUR+int(conversations[i][j][3:5]))
Severity: Major
Found in lib/analysis/channel.py - About 45 mins to fix

Function conv_len_conv_refr_time has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def conv_len_conv_refr_time(log_dict, nicks, nick_same_list, rt_cutoff_time, cutoff_percentile):
Severity: Minor
Found in lib/analysis/channel.py - About 35 mins to fix

There are no issues that match your filters.

Category
Status