Sign upLogin

prawnpdf/prawn-table

View on GitHub
Star

Showing 29 of 29 total issues

Class Cell has 71 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Cell

      # Amount of dead space (in PDF points) inside the borders but outside the
      # content. Padding defaults to 5pt.
      #
Severity: Major
Found in lib/prawn/table/cell.rb - About 1 day to fix

    File cell.rb has 439 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'date'
module Prawn
  class Document

    # @group Experimental API
    Severity: Minor
    Found in lib/prawn/table/cell.rb - About 6 hrs to fix

      Method aggregate_cell_values has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

            def aggregate_cell_values(row_or_column, meth, aggregate)
        values = {}

        #calculate values for all cells that do not span accross multiple cells
        #this ensures that we don't have a problem if the first line includes
      Severity: Minor
      Found in lib/prawn/table/column_width_calculator.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class Table has 31 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Table
    module Interface
      # @group Experimental API

      # Set up and draw a table on this document. A block can be given, which will
      Severity: Minor
      Found in lib/prawn/table.rb - About 3 hrs to fix

        File table.rb has 322 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'prawn'
require_relative 'table/column_width_calculator'
require_relative 'table/cell'
require_relative 'table/cells'
require_relative 'table/cell/in_table'
        Severity: Minor
        Found in lib/prawn/table.rb - About 3 hrs to fix

          Method make_cells has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              def make_cells(data, cell_style = {})
      assert_proper_table_data(data)

      cells = Cells.new
          Severity: Minor
          Found in lib/prawn/table.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def border_color=(color)
        @border_colors = case
        when color.nil?
          ["000000"] * 4
        when String === color # all colors
          Severity: Major
          Found in lib/prawn/table/cell.rb and 1 other location - About 2 hrs to fix
          lib/prawn/table/cell.rb on lines 596..610

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def border_width=(width)
        @border_widths = case
        when width.nil?
          ["000000"] * 4
        when Numeric === width # all widths
          Severity: Major
          Found in lib/prawn/table/cell.rb and 1 other location - About 2 hrs to fix
          lib/prawn/table/cell.rb on lines 538..552

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method natural_widths has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

                def natural_widths
        #calculate natural column width for all rows that do not include a span dummy
        @cells.each do |cell|
          unless has_a_span_dummy?(cell.row)
            @widths_by_column[cell.column] =
          Severity: Minor
          Found in lib/prawn/table/column_width_calculator.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method make_cells has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def make_cells(data, cell_style = {})
      assert_proper_table_data(data)

      cells = Cells.new
          Severity: Minor
          Found in lib/prawn/table.rb - About 1 hr to fix

            Method draw_borders has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def draw_borders(pt)
        x, y = pt

        @pdf.mask(:line_width, :stroke_color) do
          @borders.each do |border|
            Severity: Minor
            Found in lib/prawn/table/cell.rb - About 1 hr to fix

              Method aggregate_cell_values has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def aggregate_cell_values(row_or_column, meth, aggregate)
        values = {}

        #calculate values for all cells that do not span accross multiple cells
        #this ensures that we don't have a problem if the first line includes
              Severity: Minor
              Found in lib/prawn/table/column_width_calculator.rb - About 1 hr to fix

                Method fill_values_if_needed has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                      def fill_values_if_needed(values, cell, index, meth)
        #have all spanned indices been filled with a value?
        #e.g. values[0], values[1] and values[2] don't return nil given a index of 0 and a colspan of 3
        number_of_nil_values = 0
        cell.colspan.times do |i|
                Severity: Minor
                Found in lib/prawn/table/column_width_calculator.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method draw_borders has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                      def draw_borders(pt)
        x, y = pt

        @pdf.mask(:line_width, :stroke_color) do
          @borders.each do |border|
                Severity: Minor
                Found in lib/prawn/table/cell.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method natural_widths has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def natural_widths
        #calculate natural column width for all rows that do not include a span dummy
        @cells.each do |cell|
          unless has_a_span_dummy?(cell.row)
            @widths_by_column[cell.column] =
                Severity: Minor
                Found in lib/prawn/table/column_width_calculator.rb - About 1 hr to fix

                  Method column_widths has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def column_widths
      @column_widths ||= begin
        if width - cells.min_width < -Prawn::FLOAT_PRECISION
          raise Errors::CannotFit,
            "Table's width was set too small to contain its contents " +
                  Severity: Minor
                  Found in lib/prawn/table.rb - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def height
        return height_ignoring_span if @colspan == 1 && @rowspan == 1

        # We're in a span group; get the maximum height per row (including the
        # master cell) and sum each row.
                    Severity: Minor
                    Found in lib/prawn/table/cell.rb and 1 other location - About 1 hr to fix
                    lib/prawn/table/cell.rb on lines 264..275

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def width
        return width_ignoring_span if @colspan == 1 && @rowspan == 1

        # We're in a span group; get the maximum width per column (including
        # the master cell) and sum each column.
                    Severity: Minor
                    Found in lib/prawn/table/cell.rb and 1 other location - About 1 hr to fix
                    lib/prawn/table/cell.rb on lines 321..331

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method []= has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def []=(row, col, cell) # :nodoc:
        cell.extend(Cell::InTable)
        cell.row = row
        cell.column = col
                    Severity: Minor
                    Found in lib/prawn/table/cells.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def min_width
        return min_width_ignoring_span if @colspan == 1

        # Sum up the largest min-width from each column, including myself.
        min_widths = Hash.new(0)
                    Severity: Minor
                    Found in lib/prawn/table/cell.rb and 1 other location - About 50 mins to fix
                    lib/prawn/table/cell.rb on lines 97..108

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 43.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language