prebid/Prebid.js

View on GitHub

Showing 4,826 of 4,826 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const spec = {
  code: BIDDER_CODE,
  supportedMediaTypes: [BANNER],
  isBidRequestValid,
  buildRequests,
Severity: Minor
Found in modules/deltaprojectsBidAdapter.js and 1 other location - About 35 mins to fix
modules/koblerBidAdapter.js on lines 255..263

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&reqformat=rtb_json&bidder=prebid` + (params.query ? '&' + params.query : '');
Severity: Minor
Found in modules/cleanmedianetBidAdapter.js and 1 other location - About 35 mins to fix
modules/gamoshiBidAdapter.js on lines 85..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (syncOptions.pixelEnabled) {
      syncs.push({
        type: 'image',
        url: `//${SYNC_ENDPOINT}/match/sp?${params}`
      });
Severity: Minor
Found in modules/programmaticaBidAdapter.js and 1 other location - About 35 mins to fix
modules/programmaticaBidAdapter.js on lines 117..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return bid.pbCg;
Severity: Major
Found in src/auction.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return (safeResults[referenceIndex] = '<' + value + '...(see console)>');
    Severity: Major
    Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return '<complexity exceeded>';
      Severity: Major
      Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in src/adapters/bidderFactory.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return value;
          Severity: Major
          Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return true;
            Severity: Major
            Found in src/adapters/bidderFactory.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return bid.pbHg;
              Severity: Major
              Found in src/auction.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return false;
                Severity: Major
                Found in src/utils.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return false;
                  Severity: Major
                  Found in src/adapters/bidderFactory.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return true;
                    Severity: Major
                    Found in src/config.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return value;
                      Severity: Major
                      Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return `${value}`;
                        Severity: Major
                        Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return true;
                          Severity: Major
                          Found in src/utils.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return false;
                            Severity: Major
                            Found in src/config.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                        return safe;
                              Severity: Major
                              Found in integrationExamples/videoModule/eventsUI/eventsUI.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                  return true;
                                Severity: Major
                                Found in src/native.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                      return true;
                                  Severity: Major
                                  Found in src/userSync.js - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language