Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/dailymotionBidAdapter.js

Summary

Maintainability
C
1 day
Test Coverage

Function buildRequests has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildRequests: function(validBidRequests = [], bidderRequest) {
    // check consent to be able to read user cookie
    const allowCookieReading =
      // No GDPR applies
      !deepAccess(bidderRequest, 'gdprConsent.gdprApplies') ||
Severity: Major
Found in modules/dailymotionBidAdapter.js - About 3 hrs to fix

    Function getVideoMetadata has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getVideoMetadata(bidRequest, bidderRequest) {
  const videoParams = deepAccess(bidRequest, 'params.video', {});

  // As per oRTB 2.5 spec, "A bid request must not contain both an App and a Site object."
  // See section 3.2.14
    Severity: Major
    Found in modules/dailymotionBidAdapter.js - About 2 hrs to fix

      Function getVideoMetadata has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function getVideoMetadata(bidRequest, bidderRequest) {
  const videoParams = deepAccess(bidRequest, 'params.video', {});

  // As per oRTB 2.5 spec, "A bid request must not contain both an App and a Site object."
  // See section 3.2.14
      Severity: Minor
      Found in modules/dailymotionBidAdapter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isBidRequestValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        isBidRequestValid: function (bid) {
    if (bid?.params) {
      // We only accept video adUnits
      if (!bid?.mediaTypes?.[VIDEO]) return false;
      Severity: Minor
      Found in modules/dailymotionBidAdapter.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status