prefeiturasp/SME-PratoAberto-Editor

View on GitHub
analises.py

Summary

Maintainability
D
2 days
Test Coverage

Function post_idades_idades has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def post_idades_idades():
    escolas = get_escolas()
    headers = {'Content-type': 'application/json'}
    count = 0
    dic_refeicoes = {
Severity: Minor
Found in analises.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File analises.py has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import collections
import configparser
import datetime
import itertools

Severity: Minor
Found in analises.py - About 3 hrs to fix

    Function post_ordenar_refeicoes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def post_ordenar_refeicoes():
        escolas = get_escolas()
        headers = {'Content-type': 'application/json'}
        count = 0
    
    
    Severity: Minor
    Found in analises.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update_receitas_terceirizadas has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def update_receitas_terceirizadas():
        r = db_functions.select_all_receitas_terceirizadas()
        modificacoes = []
        for row in r:
            row_aux = list(row[1:])
    Severity: Minor
    Found in analises.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function post_cardapio_add_merendas has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def post_cardapio_add_merendas():
        FILE = './tmp/Escolas x Tipo Refeição_Texto'
    
        with open(FILE, 'r', encoding="ISO-8859-1") as f:
            refeicao_escola = {}
    Severity: Minor
    Found in analises.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_quebras_escolas has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_quebras_escolas():
        escolas = get_escolas()
        mapa_base = collections.defaultdict(list)
        for escola in escolas:
            agrupamento = str(escola['agrupamento'])
    Severity: Minor
    Found in analises.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        for refeicao in escola['historico']['refeicoes']:
                            if refeicao in dic_refeicoes.keys():
                                refeicao_aux.append(dic_refeicoes[refeicao])
                            else:
                                refeicao_aux.append(refeicao)
    Severity: Major
    Found in analises.py - About 45 mins to fix

      Function get_cardapios_iguais has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_cardapios_iguais():
          url = api + '/cardapios?status=PENDENTE&status=SALVO'
          r = requests.get(url)
          refeicoes = r.json()
      
      
      Severity: Minor
      Found in analises.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function open_csv has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def open_csv():
          path = './tmp'
          file = 'Cardapios Novos.csv'
      
          cardapio = []
      Severity: Minor
      Found in analises.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_cardapios has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_cardapios():
          url = api + '/editor/cardapios?status=PENDENTE&status=SALVO&status=PUBLICADO'
          r = requests.get(url)
          refeicoes = r.json()
      
      
      Severity: Minor
      Found in analises.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

                  r = requests.post(api + '/editor/escola/{}'.format(str(escola['_id'])),
                                    data=json.dumps(escola),
      Severity: Major
      Found in analises.py and 3 other locations - About 1 hr to fix
      analises.py on lines 162..163
      analises.py on lines 256..257
      analises.py on lines 286..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              r = requests.post(api + '/editor/escola/{}'.format(str(escola['_id'])),
                                data=json.dumps(escola),
      Severity: Major
      Found in analises.py and 3 other locations - About 1 hr to fix
      analises.py on lines 215..216
      analises.py on lines 256..257
      analises.py on lines 286..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              r = requests.post(api + '/editor/escola/{}'.format(str(escola['_id'])),
                                data=json.dumps(escola),
      Severity: Major
      Found in analises.py and 3 other locations - About 1 hr to fix
      analises.py on lines 162..163
      analises.py on lines 215..216
      analises.py on lines 286..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

                  r = requests.post(api + '/editor/escola/{}'.format(str(escola['_id'])),
                                data=json.dumps(escola),
      Severity: Major
      Found in analises.py and 3 other locations - About 1 hr to fix
      analises.py on lines 162..163
      analises.py on lines 215..216
      analises.py on lines 256..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                              if refeicao in dic_refeicoes.keys():
                                  refeicao_aux.append(dic_refeicoes[refeicao])
                              else:
                                  refeicao_aux.append(refeicao)
      Severity: Major
      Found in analises.py and 1 other location - About 1 hr to fix
      analises.py on lines 195..199

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  for refeicao in escola['refeicoes']:
                      if refeicao in dic_refeicoes.keys():
                          refeicao_aux.append(dic_refeicoes[refeicao])
                      else:
                          refeicao_aux.append(refeicao)
      Severity: Major
      Found in analises.py and 1 other location - About 1 hr to fix
      analises.py on lines 208..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status