Sign upLogin

prescottprue/fireadmin

View on GitHub
Star
functions/src/actionRunner/actions.ts

Summary

Maintainability
C
1 day
Test Coverage

File actions.ts has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as admin from 'firebase-admin'
import { get, chunk, isObject } from 'lodash'
import { batchCopyBetweenFirestoreRefs } from './utils'
import { downloadFromStorage, uploadToStorage } from '../utils/cloudStorage'
import { to, promiseWaterfall } from '../utils/async'
Severity: Minor
Found in functions/src/actionRunner/actions.ts - About 2 hrs to fix

    Function copyFromFirestoreToRTDB has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function copyFromFirestoreToRTDB(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
    Severity: Minor
    Found in functions/src/actionRunner/actions.ts - About 1 hr to fix

      Function batchCopyBetweenRTDBInstances has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function batchCopyBetweenRTDBInstances(
  app1: admin.app.App,
  app2: admin.app.App,
  step: ActionStep,
  inputValues: any[],
      Severity: Minor
      Found in functions/src/actionRunner/actions.ts - About 1 hr to fix

        Function copyBetweenRTDBInstances has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function copyBetweenRTDBInstances(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
        Severity: Minor
        Found in functions/src/actionRunner/actions.ts - About 1 hr to fix

          Function copyPathBetweenRTDBInstances has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export async function copyPathBetweenRTDBInstances(
  app1: admin.app.App,
  app2: admin.app.App,
  srcPath: string,
  destPath: string
          Severity: Minor
          Found in functions/src/actionRunner/actions.ts - About 1 hr to fix

            Function batchCopyBetweenRTDBInstances has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              app1: admin.app.App,
  app2: admin.app.App,
  step: ActionStep,
  inputValues: any[],
  eventData: ActionRunnerEventData
            Severity: Minor
            Found in functions/src/actionRunner/actions.ts - About 35 mins to fix

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

              export async function copyBetweenFirestoreInstances(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
              Severity: Major
              Found in functions/src/actionRunner/actions.ts and 3 other locations - About 30 mins to fix
              functions/src/actionRunner/actions.ts on lines 83..137
              functions/src/actionRunner/actions.ts on lines 147..167
              functions/src/actionRunner/actions.ts on lines 190..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

              export async function copyFromFirestoreToRTDB(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
              Severity: Major
              Found in functions/src/actionRunner/actions.ts and 3 other locations - About 30 mins to fix
              functions/src/actionRunner/actions.ts on lines 36..73
              functions/src/actionRunner/actions.ts on lines 147..167
              functions/src/actionRunner/actions.ts on lines 190..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

              export async function copyFromRTDBToFirestore(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
              Severity: Major
              Found in functions/src/actionRunner/actions.ts and 3 other locations - About 30 mins to fix
              functions/src/actionRunner/actions.ts on lines 36..73
              functions/src/actionRunner/actions.ts on lines 83..137
              functions/src/actionRunner/actions.ts on lines 190..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

              export async function copyBetweenRTDBInstances(
  app1: admin.app.App,
  app2: admin.app.App,
  eventData: ActionStep,
  inputValues: any[]
              Severity: Major
              Found in functions/src/actionRunner/actions.ts and 3 other locations - About 30 mins to fix
              functions/src/actionRunner/actions.ts on lines 36..73
              functions/src/actionRunner/actions.ts on lines 83..137
              functions/src/actionRunner/actions.ts on lines 147..167

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status