Sign upLogin

prescottprue/fireadmin

View on GitHub
Star

Showing 76 of 224 total issues

Function getAppFromServiceAccount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export async function getAppFromServiceAccount(opts, eventData: ActionRunnerEventData): Promise<admin.app.App> {
  const { databaseURL, storageBucket, environmentKey, id } = opts
  if (!databaseURL) {
    throw new Error(
      'databaseURL is required for action to authenticate through serviceAccount'
Severity: Minor
Found in functions/src/utils/serviceAccounts.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function runAction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default async function runAction(
  snap: admin.database.DataSnapshot,
  context: functions.EventContext
): Promise<null> {
  const eventData = snap.val() || {}
Severity: Minor
Found in functions/src/actionRunner/runAction.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ProjectEventsPage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function ProjectEventsPage({ projectId }) {
  const classes = useStyles()
  const firestore = useFirestore()
  const database = useDatabase()
  const displayNamesRef = database.ref(DISPLAY_NAMES_PATH)
Severity: Minor
Found in src/routes/Projects/routes/Project/routes/ProjectEvents/components/ProjectEventsPage/ProjectEventsPage.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function AddEnvironmentDialog has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function AddEnvironmentDialog({ onSubmit, projectId, onRequestClose, open }) {
  const classes = useStyles()
  const [droppedFiles, updateDroppedFiles] = useState([])
  const [selectedServiceAccountInd, changeSelectedServiceAccount] =
    useState(null)
Severity: Minor
Found in src/routes/Projects/routes/Project/routes/Environments/components/AddEnvironmentDialog/AddEnvironmentDialog.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SidebarItem has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function SidebarItem({ frontmatter, trimmedPath, childPages }) {
  const childChapters = getChildChapters(childPages)
  const parentMatchesPath = slugIsInCurrentPath(frontmatter.slug)
  const [sidebarOpen, changeOpenState] = useState(false)
  function toggleOpen() {
Severity: Minor
Found in docs/src/components/SidebarItem/SidebarItem.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useNewMemberModal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function useNewMemberModal({ projectId, onRequestClose, open }) {
  const { showError, showSuccess } = useNotifications()

  // State Management
  const [selectedCollaborators, changeSelectedCollaborators] = useState([])
Severity: Minor
Found in src/routes/Projects/routes/Project/routes/Permissions/components/NewMemberModal/useNewMemberModal.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return batchCopyBetweenRTDBInstances(
          app1,
          app2,
          step,
          convertedInputValues,
Severity: Major
Found in functions/src/actionRunner/runSteps.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return copyFromStorageToRTDB(app1, app2, step)
    Severity: Major
    Found in functions/src/actionRunner/runSteps.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return copyFromRTDBToStorage(app1, app2, step)
      Severity: Major
      Found in functions/src/actionRunner/runSteps.ts - About 30 mins to fix

        Function PermissionsTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function PermissionsTable({ projectId }) {
  const classes = useStyles()
  const { showError, showSuccess } = useNotifications()
  const [deleteDialogOpen, changeDeleteDialogOpen] = useState(false)
  const [selectedMemberId, changeSelectedMemberId] = useState('')
        Severity: Minor
        Found in src/routes/Projects/routes/Project/routes/Permissions/components/PermissionsTable/PermissionsTable.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function FilesUploader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function FilesUploader({
  onFilesDrop,
  isUploading,
  isCompact,
  maxSelection,
        Severity: Minor
        Found in src/routes/Projects/routes/Project/routes/Environments/components/FilesUploader/FilesUploader.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function downloadFromStorage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function downloadFromStorage(
  app: admin.app.App | null,
  pathInStorage: string
): Promise<any> {
  if (app && !app.storage) {
        Severity: Minor
        Found in functions/src/utils/cloudStorage.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function shallowRtdbGet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export async function shallowRtdbGet(opts, rtdbPath: string | undefined): Promise<any> {
  const { projectId, environmentId, databaseName } = opts
  if (!environmentId) {
    throw new Error(
      'environmentId is required for action to authenticate through serviceAccount'
        Severity: Minor
        Found in functions/src/actionRunner/utils.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setAnalyticsUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function setAnalyticsUser(auth) {
  if (auth && auth.uid) {
    if (process.env.REACT_APP_FIREBASE_measurementId) {
      firebase.analytics().setUserId(auth.uid)
      firebase.analytics().setUserProperties({
        Severity: Minor
        Found in src/utils/analytics.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function useActionTemplatePage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function useActionTemplatePage({ templateId }) {
  const history = useHistory()
  const firestore = useFirestore()
  const { FieldValue } = useFirestore
  const { showError, showSuccess } = useNotifications()
        Severity: Minor
        Found in src/routes/ActionTemplate/components/ActionTemplatePage/ActionTemplatePage.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleServiceAccountCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        async function handleServiceAccountCreate(
  snap: functions.firestore.DocumentSnapshot
): Promise<null> {
  const eventData = snap.data()
  if (!eventData?.serviceAccount) {
        Severity: Minor
        Found in functions/src/copyServiceAccountToFirestore/index.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language