presidentbeef/brakeman

Consider simplifying this complex logical expression.

Open

    if not protected_by_raise?(call) and
        not only_path?(call) and
        not explicit_host?(opt) and
        not slice_call?(opt) and
        not safe_permit?(opt) and

Avoid deeply nested control flow statements.

Open

           if string? v
             add_route_from_string v[1]
           elsif in_controller_block? and symbol? v
             add_route v
           end

Avoid deeply nested control flow statements.

Open

            return match if match

Avoid deeply nested control flow statements.

Open

            if @app_tree.layout_exists?(name)
              @current_class.layout = "layouts/#{name}"
            else
              Brakeman.debug "[Notice] Layout not found: #{name}"
            end

Avoid deeply nested control flow statements.

Open

          if exp.value.node_type == :rlist
            exp.value.each_sexp do |e|
              if match = has_immediate_model?(e, out)
                return match
              end

Avoid deeply nested control flow statements.

Open

          process block if sexp? block

Avoid deeply nested control flow statements.

Open

          if exp.value.node_type == :rlist
            exp.value.each_sexp do |e|
              match = has_immediate_user_input?(e)
              return match if match
            end

Avoid deeply nested control flow statements.

Open

            return match if match

Avoid deeply nested control flow statements.

Open

            if exp.method == :to_json
              message << msg_plain(" in JSON hash")
              link_path += "_to_json"
              warning_code = :xss_to_json
            end

Avoid deeply nested control flow statements.

Open

          if string? v
            add_route_from_string v
          else
            add_route v
          end

Avoid deeply nested control flow statements.

Open

          elsif node_type? last_arg, :nil, :false
            #layout :false or layout nil
            @current_class.layout = false

Avoid deeply nested control flow statements.

Open

            if t.is_a? Symbol
              :"#{t}.#{exp.method}"
            else
              exp
            end

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def get_rails_config exp
    if node_type? exp, :attrasgn
      attribute = exp.method.to_s[0..-2].to_sym
      get_rails_config(exp.target) << attribute
    elsif call? exp

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def get_rails_config exp
    if node_type? exp, :attrasgn
      attribute = exp.method.to_s[0..-2].to_sym
      get_rails_config(exp.target) << attribute
    elsif call? exp

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

    if call? target and target.method == :connection
      target = target.target
      klass = class_name(target)

      target.nil? or

Consider simplifying this complex logical expression.

Open

    if node_type? exp, :or
      decorated_model? exp.lhs or decorated_model? exp.rhs
    else
      tracker.config.has_gem? :draper and
      call? exp and

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def initialize name, parent, file_name, src, tracker

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def initialize name, parent, file_name, src, tracker

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def initialize name, parent, file_name, src, tracker

Method process_template has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def process_template name, src, type, called_from = nil, file_name = nil