prey/prey-node-client

View on GitHub

Showing 551 of 551 total issues

Avoid too many return statements within this function.
Open

      return False
Severity: Major
Found in lib/conf/gui/mac/PreyConfig.app/Contents/MacOS/prey-config.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return False
    Severity: Major
    Found in lib/conf/gui/linux/prey-config3.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return False
      Severity: Major
      Found in lib/conf/gui/linux/prey-config3.py - About 30 mins to fix

        Function setEmpty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.setEmpty = function (values, cb) {
          const { key } = values;
          if (key === 'control-panel') return cb(new Error(`${key} is not able to be empty.`));
          const expReg = /.*/;
          const dataFromName = reqPreyConf.filter((item) => item.name === key);
        Severity: Minor
        Found in lib/conf/settings.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function watch_stopped has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const watch_stopped = function () {
          if (!watching) return;
        
          hooks.on('action', (event, id) => {
            if (event == 'stopped' || event == 'failed') {
        Severity: Minor
        Found in lib/agent/commands.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_picture has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.get_picture = (callback) => {
          socket.writeMessage(nameArray[2], (err, data) => {
            if (err) return exports.get_picture_old(callback);
            try {
              if (data.result.success.toString().localeCompare('false') === 0) return done(new Error("Couldn't get picture"), null, callback);
        Severity: Minor
        Found in lib/agent/providers/webcam/mac/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const send = function (what, data, opts, cb) {
          var opts = opts || {};
        
          const done = function (err, resp) {
            const str = err ? `Got error: ${err.message}` : `Got ${resp.statusCode} response: ${resp.body}`;
        Severity: Minor
        Found in lib/agent/control-panel/sender.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_firmware_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.get_firmware_info = (callback) => {
          getSystemProfilerData('SPHardwareDataType', (err, spData) => {
            if (err) return callback(err);
            const data = {
              device_type: spData.model_name.indexOf('Book') === -1 ? 'Desktop' : 'Laptop',
        Severity: Minor
        Found in lib/agent/providers/hardware/mac.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.send = (err, cb) => {
          const { release } = require('os');
          const { version } = require('./common');
          const keys = require('./agent/control-panel/api/keys');
          // prevent exceptions from being sent when running tests
        Severity: Minor
        Found in lib/exceptions.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_logged_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        system.get_logged_user = (cb) => {
          system.find_logged_user((e, user) => {
            if (e || !user || user.trim() == '') {
              const err = new Error('No logged user detected.');
              if (e) err.message += ` ${e.message}`;
        Severity: Minor
        Found in lib/system/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function retrieve_old_keys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.retrieve_old_keys = function (file, cb) {
          log(`Reading config keys from file: ${file}`);
        
          fs.readFile(file, (err, data) => {
            if (err) {
        Severity: Minor
        Found in lib/conf/shared/keys.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_screenshot has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.get_screenshot = (callback) => {
          // eslint-disable-next-line consistent-return
          osFunctions.get_screenshot((err, filePath, fileType) => {
            if (err) return callback(err);
        
        
        Severity: Minor
        Found in lib/agent/providers/screenshot/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_admin_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        system.get_admin_user = remember((cb) => {
          system.find_admin_user((e, user) => {
            if (e || !user || user.trim() == '') {
              const err = new Error('No admin user detected.');
              if (e) err.message += ` ${e.message}`;
        Severity: Minor
        Found in lib/system/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.update = function (values, cb) {
          const key = values.positional[0];
          const val = values.positional[1];
          const dataFromName = reqPreyConf.filter((item) => item.name === key);
          const dataToSave = (val.toLowerCase() === 'true' || val.toLowerCase() === 'false') ? isBoolean(val) : val;
        Severity: Minor
        Found in lib/conf/settings.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function set_current has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        versions.set_current = function (version, cb) {
          if (!paths.versions)
            return cb();
        
          if (version == 'latest')
        Severity: Minor
        Found in lib/conf/shared/version_manager.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function stop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function stop() {
          if (timer)
            clearTimeout(timer);
        
          if (child) {
        Severity: Minor
        Found in lib/agent/actions/lock/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deleteOutlookProfiles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.deleteOutlookProfiles = (cb) => {
          getProfileRegistry((err, profiles) => {
            if (err) return cb();
        
            profiles.forEach((profile, index) => {
        Severity: Minor
        Found in lib/agent/actions/wipe/windows/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        var get = exports.get = function(name, extra) {
        
          var args = arguments,
              cb,
              options;
        Severity: Minor
        Found in lib/agent/providers.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function shutdown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function shutdown(code, wait) {
          var wait = wait || 10000;
        
          const die = function (graceful) {
            const msg = graceful ? 'Shutdown complete.' : "Time's up, shutdown forced.";
        Severity: Minor
        Found in lib/agent/cli.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function activate_event has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.activate_event = (trigger) => {
          let eventIndex;
          try {
            eventIndex = trigger.automation_events.findIndex((obj) => eventsList.indexOf(obj.type) > -1);
          } catch (e) {
        Severity: Minor
        Found in lib/agent/actions/triggers/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language