privly/privly-applications

View on GitHub
build.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function get_link_creation_apps has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def get_link_creation_apps():
  """
  Gets a list of the apps that will be included in the top navigation
  for generating new links
  """
Severity: Minor
Found in build.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

        if not is_build_target(template):
          continue

Severity: Major
Found in build.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

              if "nav" in template.keys() and template["nav"] == "new":
                creation_apps.append(template["subtemplate_dict"]["name"])
    
      # Hack to maintain current app order
      creation_apps.sort()
    Severity: Major
    Found in build.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status