Sign upLogin

privly/privly-web

View on GitHub
Star
app/controllers/users/invitations_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    
    if not params[:user] or not params[:user][:email]
      return
    end
Severity: Minor
Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    
    if not params[:user] or not params[:user][:email]
      return
    end
    Severity: Minor
    Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method use_invite has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def use_invite
    
    # Make sure the user has invites remaining
    if current_user.alpha_invites < 1
      redirect_to pages_account_path, :notice => "You do not have any invitations at this time."
    Severity: Minor
    Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix

      Method use_invite has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def use_invite
    
    # Make sure the user has invites remaining
    if current_user.alpha_invites < 1
      redirect_to pages_account_path, :notice => "You do not have any invitations at this time."
      Severity: Minor
      Found in app/controllers/users/invitations_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status