Sign upLogin

privly/privly-web

View on GitHub
Star

Showing 98 of 98 total issues

Function createLinks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  createLinks: function() 
  {
      /*************************************************************************
      Inspired by Linkify script:
        http://downloads.mozdev.org/greasemonkey/linkify.user.js
Severity: Minor
Found in public/cdn/privly-0.1.1.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  addEvent: function(obj, evType, fn){
    
    "use strict";
    
    if (obj.addEventListener){
Severity: Major
Found in public/cdn/privly-0.1.2.js and 1 other location - About 1 hr to fix
public/cdn/privly-0.1.1.js on lines 261..271

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createLinks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
Severity: Minor
Found in public/cdn/privly.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  addEvent: function(obj, evType, fn){ 
   if (obj.addEventListener){ 
     obj.addEventListener(evType, fn, false); 
     return true; 
   } else if (obj.attachEvent){
Severity: Major
Found in public/cdn/privly-0.1.1.js and 1 other location - About 1 hr to fix
public/cdn/privly-0.1.2.js on lines 740..755

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      var $this = $(this)
        , data = $this.data('modal')
        , options = $.extend({}, $.fn.modal.defaults, $this.data(), typeof option == 'object' && option)
Severity: Major
Found in app/assets/javascripts/bootstrap.js and 1 other location - About 1 hr to fix
app/assets/javascripts/bootstrap.js on lines 597..599

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function createLinks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
Severity: Minor
Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createLinks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
Severity: Minor
Found in public/cdn/privly-0.1.3.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  , show: function () {
      var $tip
        , pos
        , actualWidth
        , actualHeight
Severity: Minor
Found in app/assets/javascripts/bootstrap.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        if (!exclude && privlyExcludeUndefined) {
      
      var passive = this.extensionMode === privly.extensionModeEnum.PASSIVE ||
        params.passive !== undefined ||  params.privlyPassive !== undefined ||
        !whitelist || privly.nextAvailableFrameID > 39;
    Severity: Critical
    Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

      Function replaceLink has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        replaceLink: function(object)
  {
    "use strict";
    
    var iFrame = document.createElement('iframe');
      Severity: Minor
      Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

        Function createLinks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
        Severity: Minor
        Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

          Function createLinks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
          Severity: Minor
          Found in public/cdn/privly-0.1.3.js - About 1 hr to fix

            Function createLinks has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              createLinks: function()
  {
    "use strict";
    /***********************************************************************
    Inspired by Linkify script:
            Severity: Minor
            Found in public/cdn/privly.js - About 1 hr to fix

              Function getUrlVariables has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                getUrlVariables: function(url) {
    
    "use strict";
    
    var vars = {};
              Severity: Minor
              Found in public/cdn/privly-0.1.2.js - About 1 hr to fix

                Function replaceLinks has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                  replaceLinks: function(){
    var anchors = document.links;
    var i = anchors.length;
    while (i--){
      var a = anchors[i];
                Severity: Minor
                Found in public/cdn/privly-0.1.1.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def create
    @user = User.find_by_email(params[:email])
    
    if @user and not @user.valid_password?(params[:password])
      @user.failed_attempts += 1
                Severity: Minor
                Found in app/controllers/token_authentications_controller.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            $.support.transition && this.$element.hasClass('fade')?
            this.$backdrop.one($.support.transition.end, callback) :
            callback()
                  Severity: Major
                  Found in app/assets/javascripts/bootstrap.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/bootstrap.js on lines 578..580

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        $.support.transition && this.$element.hasClass('collapse') ?
        this.$element.one($.support.transition.end, complete) :
        complete()
                  Severity: Major
                  Found in app/assets/javascripts/bootstrap.js and 1 other location - About 1 hr to fix
                  app/assets/javascripts/bootstrap.js on lines 986..988

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function createLinks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    createLinks: function() 
  {
      /*************************************************************************
      Inspired by Linkify script:
        http://downloads.mozdev.org/greasemonkey/linkify.user.js
                  Severity: Minor
                  Found in public/cdn/privly-0.1.1.js - About 1 hr to fix

                    Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def create
    
    if not params[:user] or not params[:user][:email]
      return
    end
                    Severity: Minor
                    Found in app/controllers/users/invitations_controller.rb - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language