Sign upLogin

programandoarg/pg_rails

View on GitHub
Star

Showing 25 of 30 total issues

Method do_sort has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
Open

    def do_sort(scope, field, direction)
      # TODO: restringir ciertos campos?
      unless scope.model.column_names.include?(field.to_s) ||
             scope.model.respond_to?("order_by_#{field}")
        pg_warn("No existe el campo \"#{field}\"")
Severity: Minor
Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (document.getElementById('sidebar').classList.toggle('opened')) {
      icon.classList.add('bi-chevron-left')
      icon.classList.remove('bi-chevron-right')
      fadeOut(document.querySelector('.navbar .navbar-brand'))
    } else {
Severity: Minor
Found in pg_layout/app/javascript/controllers/navbar_controller.js and 1 other location - About 40 mins to fix
pg_layout/app/javascript/controllers/navbar_controller.js on lines 19..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else {
      icon.classList.remove('bi-chevron-left')
      icon.classList.add('bi-chevron-right')
      fadeIn(document.querySelector('.navbar .navbar-brand'))
    }
Severity: Minor
Found in pg_layout/app/javascript/controllers/navbar_controller.js and 1 other location - About 40 mins to fix
pg_layout/app/javascript/controllers/navbar_controller.js on lines 15..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method matches? has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
Open

        def matches?(proc)
          msg = 'have_logged only support block expectations'
          raise ArgumentError, msg unless proc.is_a?(Proc)

          original_messages = Set.new(PgEngine::PgLogger.test_logged_messages)
Severity: Minor
Found in pg_rails/lib/pg_rails/rspec_logger_matchers.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setMaxHeight has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
Confirmed

  setMaxHeight () {
    let maxHeight
    if (!this.element.closest('.modal')) {
      const scrollTop = document.scrollingElement.scrollTop
      const inputY = this.input.getBoundingClientRect().bottom + scrollTop
Severity: Minor
Found in pg_associable/app/javascript/asociable_controller.tsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language