Sign upLogin

programandoarg/pg_rails

View on GitHub
Star
pg_engine/app/controllers/concerns/pg_engine/resource.rb

Summary

Maintainability
C
1 day
Test Coverage
C
77%

File resource.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module PgEngine
  module Resource
    def self.included(clazz)
      # clazz.before_action :authenticate_user!
      clazz.helper_method :atributos_para_listar
Severity: Minor
Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 2 hrs to fix

    Method pg_respond_destroy has a Cognitive Complexity of 15 (exceeds 7 allowed). Consider refactoring.
    Confirmed

        def pg_respond_destroy(model, redirect_url = nil)
      if destroy_model(model)
        msg = "#{model.model_name.human} #{model.gender == 'f' ? 'borrada' : 'borrado'}"
        respond_to do |format|
          if redirect_url.present?
    Severity: Minor
    Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pg_respond_create has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
    Confirmed

        def pg_respond_create
      object = instancia_modelo
      respond_to do |format|
        if (@saved = object.save)
          if params[:asociable]
    Severity: Minor
    Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pg_respond_create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

        def pg_respond_create
      object = instancia_modelo
      respond_to do |format|
        if (@saved = object.save)
          if params[:asociable]
    Severity: Minor
    Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

      Method pg_respond_destroy has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def pg_respond_destroy(model, redirect_url = nil)
      if destroy_model(model)
        msg = "#{model.model_name.human} #{model.gender == 'f' ? 'borrada' : 'borrado'}"
        respond_to do |format|
          if redirect_url.present?
      Severity: Minor
      Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 1 hr to fix

        Method do_sort has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
        Open

            def do_sort(scope, field, direction)
      # TODO: restringir ciertos campos?
      unless scope.model.column_names.include?(field.to_s) ||
             scope.model.respond_to?("order_by_#{field}")
        pg_warn("No existe el campo \"#{field}\"")
        Severity: Minor
        Found in pg_engine/app/controllers/concerns/pg_engine/resource.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status