Sign upLogin

projectblacklight/blacklight

View on GitHub
Star
app/controllers/concerns/blacklight/search_context.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method find_search_session has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def find_search_session
    if agent_is_crawler?
      nil
    elsif params[:search_context].present?
      find_or_initialize_search_session_from_params JSON.parse(params[:search_context])
Severity: Minor
Found in app/controllers/concerns/blacklight/search_context.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setup_next_and_previous_documents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def setup_next_and_previous_documents
    return { counter: params[:counter] } if setup_next_and_previous_on_client?
    return nil unless setup_next_and_previous_on_server?

    index = search_session['counter'].to_i - 1
Severity: Minor
Found in app/controllers/concerns/blacklight/search_context.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method page_links has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def page_links
    counter_param = params.delete(:counter)
    @page_link_data = {}
    if counter_param
      index = counter_param.to_i - 1
Severity: Minor
Found in app/controllers/concerns/blacklight/search_context.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status