Sign upLogin

projectcypress/health-data-standards

View on GitHub
Star
lib/health-data-standards/models/cqm/measure.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method build_pre_filters! has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def build_pre_filters!
        dc = self.data_criteria.inject({}) do |all_dc, single_dc|
          key = single_dc.keys.first
          value = single_dc.values.first
          all_dc[key] = value
Severity: Minor
Found in lib/health-data-standards/models/cqm/measure.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method categories has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.categories(measure_properties = [])
        measure_properties = Array(measure_properties).map(&:to_s) | %w(
          name description nqf_id cms_id hqmf_id continuous_variable episode_of_care
        )
        pipeline = []
Severity: Minor
Found in lib/health-data-standards/models/cqm/measure.rb - About 1 hr to fix

    Method build_pre_filters! has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def build_pre_filters!
        dc = self.data_criteria.inject({}) do |all_dc, single_dc|
          key = single_dc.keys.first
          value = single_dc.values.first
          all_dc[key] = value
    Severity: Minor
    Found in lib/health-data-standards/models/cqm/measure.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if tr['range']['high']
                      prefilter.comparison = '$gte'
                      years = tr['range']['high']['value'].to_i
                    elsif tr['range']['low']
                      prefilter.comparison = '$lte'
      Severity: Major
      Found in lib/health-data-standards/models/cqm/measure.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status