Sign upLogin

projectcypress/health-data-standards

View on GitHub
Star
lib/hqmf-generator/hqmf-generator.rb

Summary

Maintainability
D
1 day
Test Coverage

Class ErbContext has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ErbContext < OpenStruct


      def initialize(vars)
        super(vars)
Severity: Minor
Found in lib/hqmf-generator/hqmf-generator.rb - About 4 hrs to fix

    File hqmf-generator.rb has 353 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module HQMF2
  module Generator

    def self.render_template(name, params)
      template_path = File.expand_path(File.join('..', "#{name}.xml.erb"), __FILE__)
    Severity: Minor
    Found in lib/hqmf-generator/hqmf-generator.rb - About 4 hrs to fix

      Method data_criteria_template_name has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def data_criteria_template_name(data_criteria)
        case data_criteria.definition
        when 'diagnosis', 'diagnosis_family_history'
          'condition_criteria'
        when 'encounter'
      Severity: Minor
      Found in lib/hqmf-generator/hqmf-generator.rb - About 1 hr to fix

        Method reference_type_name has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def reference_type_name(id)
        referenced_criteria = doc.data_criteria(id)
        type = nil
        if referenced_criteria
          type = referenced_criteria.type
        Severity: Minor
        Found in lib/hqmf-generator/hqmf-generator.rb - About 1 hr to fix

          Method data_criteria_template_name has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def data_criteria_template_name(data_criteria)
        case data_criteria.definition
        when 'diagnosis', 'diagnosis_family_history'
          'condition_criteria'
        when 'encounter'
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method xml_for_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def xml_for_fields(criteria)
        fields = []
        if criteria.field_values
          criteria.field_values.each_pair do |key, value|
            if key == "FLFS"
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method reference_type_name has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def reference_type_name(id)
        referenced_criteria = doc.data_criteria(id)
        type = nil
        if referenced_criteria
          type = referenced_criteria.type
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method data_criteria_should_be_grouper? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def data_criteria_should_be_grouper?(criteria)
        return false unless criteria
        return false unless criteria.definition == 'derived'
        return true unless criteria.subset_operators
        criteria.subset_operators.all? {|o| o.supports_grouper_criteria?}
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method xml_for_local_variable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def xml_for_local_variable(criteria)
        name = @local_var_names[criteria.id]
        unless name
          if criteria.specific_occurrence && !criteria.id.starts_with?("Occurrence#{criteria.specific_occurrence}")
            name = "Occurrence#{criteria.specific_occurrence}#{criteria.id}"
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method element_name_prefix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def element_name_prefix(data_criteria)
        type = data_criteria ? data_criteria.type : :observation
        case type
        when :encounters
          'encounter'
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def xml_for_temporal_references(criteria)
        refs = []
        if criteria.temporal_references
          refs = criteria.temporal_references.collect do |reference|
            HQMF2::Generator.render_template('temporal_relationship', {'doc' => doc, 'relationship' => reference, 'criteria' => criteria})
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb and 1 other location - About 15 mins to fix
          lib/hqmf-generator/hqmf-generator.rb on lines 147..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def xml_for_subsets(data_criteria)
        subsets_xml = []
        if data_criteria.subset_operators
          subsets_xml = data_criteria.subset_operators.collect do |operator|
            HQMF2::Generator.render_template('subset', {'doc' => doc, 'subset' => operator, 'criteria' => data_criteria})
          Severity: Minor
          Found in lib/hqmf-generator/hqmf-generator.rb and 1 other location - About 15 mins to fix
          lib/hqmf-generator/hqmf-generator.rb on lines 178..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status