Sign upLogin

projectcypress/health-data-standards

View on GitHub
Star
test/unit/validate/performance_rate_validator_test.rb

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals .285714 reported .285715" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 25..39
test/unit/validate/performance_rate_validator_test.rb on lines 98..112
test/unit/validate/performance_rate_validator_test.rb on lines 132..146
test/unit/validate/performance_rate_validator_test.rb on lines 149..163
test/unit/validate/performance_rate_validator_test.rb on lines 166..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals .285714 reported .2857142857" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 25..39
test/unit/validate/performance_rate_validator_test.rb on lines 98..112
test/unit/validate/performance_rate_validator_test.rb on lines 115..129
test/unit/validate/performance_rate_validator_test.rb on lines 132..146
test/unit/validate/performance_rate_validator_test.rb on lines 166..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals NA reported 1" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 98..112
test/unit/validate/performance_rate_validator_test.rb on lines 115..129
test/unit/validate/performance_rate_validator_test.rb on lines 132..146
test/unit/validate/performance_rate_validator_test.rb on lines 149..163
test/unit/validate/performance_rate_validator_test.rb on lines 166..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals .571429 reported .571428" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 25..39
test/unit/validate/performance_rate_validator_test.rb on lines 98..112
test/unit/validate/performance_rate_validator_test.rb on lines 115..129
test/unit/validate/performance_rate_validator_test.rb on lines 132..146
test/unit/validate/performance_rate_validator_test.rb on lines 149..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals .285714 reported 28.5714" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 25..39
test/unit/validate/performance_rate_validator_test.rb on lines 98..112
test/unit/validate/performance_rate_validator_test.rb on lines 115..129
test/unit/validate/performance_rate_validator_test.rb on lines 149..163
test/unit/validate/performance_rate_validator_test.rb on lines 166..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  test "Performance Rate equals .285714 reported 1.285714" do
    errorsList = []
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 5 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 25..39
test/unit/validate/performance_rate_validator_test.rb on lines 115..129
test/unit/validate/performance_rate_validator_test.rb on lines 132..146
test/unit/validate/performance_rate_validator_test.rb on lines 149..163
test/unit/validate/performance_rate_validator_test.rb on lines 166..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  test "Performance Rate equals 1 reported 1" do
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
    reported_result['DENOM'] = 1
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 3 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 56..67
test/unit/validate/performance_rate_validator_test.rb on lines 70..81
test/unit/validate/performance_rate_validator_test.rb on lines 84..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  test "Performance Rate equals 1 reported 1.0" do
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
    reported_result['DENOM'] = 1
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 3 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 42..53
test/unit/validate/performance_rate_validator_test.rb on lines 56..67
test/unit/validate/performance_rate_validator_test.rb on lines 84..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  test "Performance Rate equals .285714 reported 0.285714" do
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
    reported_result['DENOM'] = 7
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 3 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 42..53
test/unit/validate/performance_rate_validator_test.rb on lines 56..67
test/unit/validate/performance_rate_validator_test.rb on lines 70..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  test "Performance Rate equals 0 reported 0" do
    population_ids = {}
    population_ids['NUMER'] = "test_numer"
    reported_result = {}
    reported_result['DENOM'] = 1
Severity: Major
Found in test/unit/validate/performance_rate_validator_test.rb and 3 other locations - About 1 hr to fix
test/unit/validate/performance_rate_validator_test.rb on lines 42..53
test/unit/validate/performance_rate_validator_test.rb on lines 70..81
test/unit/validate/performance_rate_validator_test.rb on lines 84..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status