Sign upLogin

projek-xyz/slim-plates

View on GitHub
Star

Showing 2 of 2 total issues

The method addFolder has a boolean flag argument $fallback, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addFolder($name, $directory, $fallback = false) : Engine
Severity: Minor
Found in src/Plates.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\Slim\Routing\RouteContext' in method '__construct'.
Open

        $this->context = RouteContext::fromRequest($request);
Severity: Minor
Found in src/PlatesExtension.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language