Sign upLogin

promiscuous-io/promiscuous

View on GitHub
Star
lib/promiscuous/publisher/operation/active_record.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method connection has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def connection
      connection_without_promiscuous.tap do |connection|
        unless defined?(connection.promiscuous_hook)
          connection.class.class_eval do
            attr_accessor :current_transaction_id
Severity: Major
Found in lib/promiscuous/publisher/operation/active_record.rb - About 2 hrs to fix

    Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(arel, name, pk, id_value, sequence_name, binds, options={})
    Severity: Major
    Found in lib/promiscuous/publisher/operation/active_record.rb - About 50 mins to fix

      Method db_operation_and_select has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def db_operation_and_select
      # XXX This is only supported by Postgres and should be in the postgres driver
      @connection.transaction do
        if @connection.supports_returning_statments?
          @connection.exec_insert("#{@connection.to_sql(@arel, @binds)} RETURNING *", @operation_name, @binds).tap do |result|
      Severity: Minor
      Found in lib/promiscuous/publisher/operation/active_record.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def execute(&db_operation)
      return db_operation.call unless model
      ensure_transaction!

      super do |query|
      Severity: Minor
      Found in lib/promiscuous/publisher/operation/active_record.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status